186643 - del key at the end of the urlbar asserts

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[timeless]

cvs build from sunday afternoon, no patches to editor.

place the cursor at the end of the urlbar input and press delete.

###!!! ASSERTION: null node passed to nsHTMLEditUtils::NodeIsType: 'aNode', file
i:/build/mozilla/editor/libeditor/text/nsTextEditUtils.cpp, line 54
Break: at file i:/build/mozilla/editor/libeditor/text/nsTextEditUtils.cpp, line 54

nsTextEditUtils::NodeIsType(nsIDOMNode * 0x00000000, const nsAString & {...})
line 55
nsTextEditUtils::IsBreak(nsIDOMNode * 0x00000000) line 86 + 26 bytes
nsTextEditRules::WillDeleteSelection(nsISelection * 0x0e874418, short 1, int *
0x0012e944, int * 0x0012e980) line 940 + 27 bytes
nsTextEditRules::WillDoAction(nsTextEditRules * const 0x0e8752a0, nsISelection *
0x0e874418, nsRulesInfo * 0x0012e948, int * 0x0012e944, int * 0x0012e980) line
292 + 28 bytes
nsPlaintextEditor::DeleteSelection(nsPlaintextEditor * const 0x0e8740e0, short
1) line 962 + 59 bytes
nsTextEditorKeyListener::KeyPress(nsTextEditorKeyListener * const 0x0e876458,
nsIDOMEvent * 0x161a1b10) line 274b

Comment 1

[Olivier Cahagne]

confirming using debug linux build 20021220.

Comment 2

[timeless]

Attachment: fix

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 110090 [details] [diff] [review]
fix

r=glazman

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 110090 [details] [diff] [review]
fix

Wait, I am reconsidering my r=. I would rather see the nulltest in
http://lxr.mozilla.org/seamonkey/source/editor/libeditor/text/nsTextEditRules.c
pp#939

Comment 5

[Joe Francis]

Attachment: simpler fix

Just a null check is all we need.  Thanks for investigating this timeless.

Comment 6

[timeless]

checked in, thanks