Closed
Bug 1866451
Opened 2 years ago
Closed 2 years ago
Limit number of parallel IonFreeTasks
Categories
(Core :: JavaScript Engine: JIT, task)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
(Whiteboard: [sp3])
Attachments
(1 file)
These are low-priority tasks (nothing is blocked on them) that are just freeing memory, so if we run multiple of these tasks in parallel it's more likely that we hit jemalloc lock contention issues. This would also block higher-priority tasks if all threads are occupied.
Similar to the source compression tasks, I think we should limit these to one active task. After this we can also try batching more compilation tasks into a single IonFreeTask.
The latest perf comparison has some medium-confidence improvements for sp3 sub tests, so I think it's worth trying:
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-657
| Assignee | ||
Comment 1•2 years ago
|
||
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f6a51cc4271
Limit number of parallel IonFreeTasks to 1. r=jonco
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•