1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Delia Pop (Android QA)]

Attachment: Incorrect status is displayed after turning off the Cookie Banner Blocker from the panel.mp4

Preconditions

Have the Cookie Banner Blocker feature enabled (Settings -> Cookie Banner Blocker in private browsing toggled)

Steps to reproduce

1. Navigate to a supported website with a cookie banner (eg. cnn.com).
2. Tap on the lock icon to open the bottom panel.
3. Tap on the "Cookie Banner Blocker" section.
4. Untoggle/turn off the Cookie Banner Blocker for this website from the panel.
5. Tap the back arrow and observe the status displayed in the "Cookie Banner Blocker" section.

Expected behavior

The "Off for this site" status is displayed in the "Cookie Banner Blocker" section.

Actual behavior

The "Site currently not supported" status is displayed.
The user cannot turn on the Cookie Banner Blocker feature for this website in this session.

Device information

• Firefox version: Nightly 122.0a1, Beta 121.0b2
• Android device model: Poco F5 Pro (and any other device)
• Android OS version: Android 13

Any additional information?

Comment 1

[Arturo Mejia [:amejia]]

Thanks for reporting Delia, I'll take a look!

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel (#4627)

Comment 3

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/7f9d3570ff283f2de6b08dc256083638c3d0a171
[main] Bug 1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:amejia, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel (backport #4627) (#4652)

Comment 6

[Arturo Mejia [:amejia]]

Comment on attachment 9366287 [details] [review]
[mozilla-mobile/firefox-android] Bug 1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel (backport #4627) (#4652)

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to see when they turn off CBH for a website
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We are doing some API changes that will mostly impact how the UI is presented
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366287 [details] [review]
[mozilla-mobile/firefox-android] Bug 1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel (backport #4627) (#4652)

Approved for 121.0b6.

Comment 8

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/f639090bb51454ee1f8c961c946316ff407bce60
[releases_v121] Bug 1866474 - Incorrect status is displayed after turning off the Cookie Banner Blocker feature from the panel

Comment 9

[Margareta Eliza Ciure]

Verified as fixed on Firefox Beta 121.0b6 and Nightly 122.0a1 (2023-12-04).
Devices used: Samsung Galaxy S23 Ultra (Android 13) and Motorola G9 plus (Android 11).

Comment 10

[Margareta Eliza Ciure]

Attachment: cookie_banner.mov

Comment 11

[Arturo Mejia [:amejia]]

Thanks Margareta!