1866503 - PanelUI's temporary panel code closes panels when menulists inside those panels close

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

Turns out you can churn out close to 100 versions of Firefox with the same bug in them? At least, I'm fairly sure this has worked this way since Australis, back in 28/29 or thereabouts. :-)

Anyway, once you hit it it's reasonably straightforward to understand what's going on:

0. when you open a panelview individually with PanelUI (the history, library, synced tabs and various other views allow doing this via their dedicated toolbar buttons, and we do it for add-ons!), we create a temporary panel and panelmultiview, all dedicated to that subview.
1. This event listener code is in charge of tidying up temporary panels when they are hidden.
2. menulists are also popups, like panels
3. when menulists close, they fire popuphiding/popuphidden events, just like panels
4. so when your panelview has a menulist that closes, they hit the popuphidden event listener.
5. the popuphidden event listener is attached to the right panel but otherwise doesn't care where the popuphidden event has come from - including menus and other stuff inside that panel itself.

(5) is where the bug is, and that closes the containing panel when the user selects an item in the menulist, which is bad. We should fix it!

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1866503 - closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r?mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49b89e35b5f5
closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c7a7ff17005
Remove almost-surely accidentally added debugging code.

Comment 4

[Iulian Moraru]

Backed out revision https://hg.mozilla.org/integration/autoland/rev/7c7a7ff170055b7a71acf914c1e6a3595742a32b for causing conflicts with backout of Bug 1866503.

• Push that caused the conflict

• Backout link

Backed out changeset https://hg.mozilla.org/integration/autoland/rev/49b89e35b5f520e73600257f7e62f6ddd2cdafc7 for causing multiple bc failures related to panelUI.

• Push with failures

• Failure log example 1

• Failure log example 2

• Failure log example 3

• Failure log example 4
  and also this mochitest-plain failures

• Backout link

Comment 5

[:Gijs (he/him)]

Oops. https://treeherder.mozilla.org/jobs?repo=try&revision=423b5b67ccace31e567964bccbdf98c12e3130e0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd41e77c123e
closing menupopups/panels inside panelviews in temporary PanelUI panels should not close those panels, r=emilio

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fd41e77c123e