186652 - Software error when recording confirmed by vote event in bug's activity

Status: RESOLVED DUPLICATE of bug 217242

(Bugzilla :: Bugzilla-General, defect)

Description

[Sergey Lipnevich]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021209
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021209

I have filed a bug, and then was able to vote for it myself, on the b.m.o using
2.17.1. I received an error screen when I hit the "vote" button, but the changes
did persist, so I got myself a NEW instead of UNCONFOIRMED bug.

Reproducible: Always

Steps to Reproduce:
1. File new bug
2. Got to your new bug
3. Click "vote for this bug"
4. Check your bug in the list and proceed to vote

Actual Results:  
Error page "Software Error" with request to mail this screen to webmaster.

Expected Results:  
I should be denied voting on my own bugs, right?

Comment 1

[Jacob Steenhagen]

Yep, it certainly does, see bug 186655.  The software error mentioned in comment
0 is:

SELECT fieldid FROM fielddefs WHERE name = 'bug_status': Table 'fielddefs' was
not locked with LOCK TABLES at globals.pl line 283.

I don't know of anything that says you shouldn't be able to vote for a bug you
filed... but you shouldn't get a software error when you do it.

Comment 2

[Jacob Steenhagen]

This error only seems to happen when you vote for a bug you filed, voting for
bugs other people have filed still sees to work fine.

Comment 3

[Jacob Steenhagen]

OK, it seems that what's happening here is that votestoconfirm for the Bugzilla
project is 1.  This means that after the first vote for a bug it changes from
UNCONFIRMED to NEW.  The software error is happening when Bugzilla tries to
record this event in the bugs activity log.

So I think we have two bugs here, but one of them is a config issue.  First,
it's silly to have the UNCONFIRMED state in bugzilla when all one has to do is
vote for their own bug to make it NEW.  So votestoconfirm should be changed to
at least 2.

The second bug is what this bug is actually about.  There's a software error
when tring to record the confirmed by vote event in the bug's activity.  This is
really bad as it causes bug history to be lost.

Comment 4

[Gervase Markham [:gerv]]

2.18 blocker - dataloss.

Gerv

Comment 5

[Dave Miller [:justdave]]

*** Bug 199925 has been marked as a duplicate of this bug. ***

Comment 6

[Bradley Baetz (:bbaetz)]

sub show_user needs to lock fielddefs for read, too.

(and procesS_bug should lock it for read, not write, but thats a separate issue)

Comment 7

[Bradley Baetz (:bbaetz)]

*** Bug 201161 has been marked as a duplicate of this bug. ***

Comment 8

[chaduv]

Looks like timeless fixed this in another bugreport.

*** This bug has been marked as a duplicate of 217242 ***