1866589 - Enable more ESLint rules over all of dom/*

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Mark Banner (:standard8)]

These are most of the remaining rules that are focussed on finding potential issues, and enabling them has found a few things.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1866589 - Enable ESLint rule no-sequences on all of dom/. r?#dom-core!

Depends on D194658

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1866589 - Enable ESLint rules no-self-assign and no-self-compare on dom/*. r?#dom-core!

Depends on D194659

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1866589 - Enable ESLint rule no-cond-assign on all of dom/*. r?#dom-core!

Depends on D194660

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1866589 - Enable ESLint rule no-unreachable for dom/*. r?#dom-core!

Depends on D194661

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1866589 - Enable ESLint rule no-useless-call on all of dom/*. r?#dom-core!

Depends on D194662

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1866589 - Enable ESLint rule consistent-return on all of dom/*. r?#dom-core!

Depends on D194663

Comment 7

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=05b97b94494479e6a8f3e1835f3085bd9c7b8977

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af70157b07a2
Enable ESLint rule no-sequences on all of dom/. r=dom-core,webrtc-reviewers,mccr8
https://hg.mozilla.org/integration/autoland/rev/eb2562a10c48
Enable ESLint rules no-self-assign and no-self-compare on dom/*. r=dom-core,mccr8
https://hg.mozilla.org/integration/autoland/rev/ba19d5b6d6bd
Enable ESLint rule no-cond-assign on all of dom/*. r=dom-core,mccr8
https://hg.mozilla.org/integration/autoland/rev/053b6d325fd7
Enable ESLint rule no-unreachable for dom/*. r=dom-core,dom-worker-reviewers,mccr8,smaug
https://hg.mozilla.org/integration/autoland/rev/be16e3ef9956
Enable ESLint rule no-useless-call on all of dom/*. r=dom-core,mccr8
https://hg.mozilla.org/integration/autoland/rev/fc53806f2f84
Enable ESLint rule consistent-return on all of dom/*. r=dom-core,jgilbert,dom-worker-reviewers,mccr8,smaug

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/af70157b07a2
https://hg.mozilla.org/mozilla-central/rev/eb2562a10c48
https://hg.mozilla.org/mozilla-central/rev/ba19d5b6d6bd
https://hg.mozilla.org/mozilla-central/rev/053b6d325fd7
https://hg.mozilla.org/mozilla-central/rev/be16e3ef9956
https://hg.mozilla.org/mozilla-central/rev/fc53806f2f84