1866620 - [Firefox Suggest Opt-in Experiment] Bring narrow layout for topPosition=false in line with topPosition=true

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

Currently the narrow layout for browser.urlbar.quicksuggest.contextualOptIn.topPosition=false looks way worse than for browser.urlbar.quicksuggest.contextualOptIn.topPosition=true. We should ideally fix this for the experiment to prevent potentially skewing results by making topPosition=false less usable.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1866620 - [Firefox Suggest Opt-in Experiment] Bring narrow layout for topPosition=false in line with topPosition=true. r=daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/413cc418d2da
[Firefox Suggest Opt-in Experiment] Bring narrow layout for topPosition=false in line with topPosition=true. r=daleharvey

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9365459 [details]
Bug 1866620 - [Firefox Suggest Opt-in Experiment] Bring narrow layout for topPosition=false in line with topPosition=true. r=daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: this is needed for a Firefox Suggest experiment that we're running in 121, supports OKR 5.2
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA has a test plan covering this
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only fixed limited to experiment
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/413cc418d2da

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365459 [details]
Bug 1866620 - [Firefox Suggest Opt-in Experiment] Bring narrow layout for topPosition=false in line with topPosition=true. r=daleharvey

Approved for 121.0b5.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3877f700c4aa

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the issue on the latest Beta 121.0b5 (Build ID: 20231129091815) and on the latest Nightly 122.0a1 (Build ID: 20231129050021) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1 x64.

• While verifying this issue I have observed that now when the browser is resized to its minimum, in the Opt-In section from the bottom the "Not Now" button jumps on a new row and both buttons are entirely displayed. But, in the Opt-In section from the top, both buttons remain in the same row.

@Dao, is this a limitation for the Opt-In section displayed in the top position? Or should we log a separate issue for this?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Cosmin Muntean [:cmuntean], Ecosystem QA from comment #7)

I have verified the issue on the latest Beta 121.0b5 (Build ID: 20231129091815) and on the latest Nightly 122.0a1 (Build ID: 20231129050021) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1 x64.

• While verifying this issue I have observed that now when the browser is resized to its minimum, in the Opt-In section from the bottom the "Not Now" button jumps on a new row and both buttons are entirely displayed. But, in the Opt-In section from the top, both buttons remain in the same row.

@Dao, is this a limitation for the Opt-In section displayed in the top position? Or should we log a separate issue for this?

There are more issue with super small windows, e.g. the description gets cut off too. I'd say this is an edge case and not a priority / shouldn't block the experiment, but worth filing anyway I would say. Thank you!

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Thank you Dao!
I have logged a general issue for the cut-off content on browser resize in Bug 1868131.