Closed Bug 1866649 Opened 2 years ago Closed 1 year ago

Remove `--brand-color-accent` and `--platform-color-accent` in favor of `--color-accent-primary` usage

Categories

(Toolkit :: Themes, task)

task

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
firefox125 --- fixed

People

(Reporter: jules, Assigned: hjones)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file)

--platform-color-accent and --brand-color-accent are tokens that store the platform (operating system) and brand accent colors under tokens-platform.css and tokens-brand.css respectively.

Under tokens-platform.css, the token that stores our UI's primary accent, --color-accent-primary, is assigned to --platform-color-accent, while under tokens-brand.css, --color-accent-primary is assigned to --brand-color-accent.

Since the --color-accent-primary token source alone implies whether it comes from the brand or platform system, these two extra tokens cause an unnecessary step. Our tokens system implies that if a token value is not coming from tokens-shared.css, then it has different values between the brand and platform contexts. Let's get rid of the --platform-color-accent and --brand-color-accent tokens and simply rely on --color-accent-primary.

Summary: Remove `--brand-color-accent` and `--platform-color-accent` in favor of `--color-accent-primary" usage → Remove `--brand-color-accent` and `--platform-color-accent` in favor of `--color-accent-primary` usage
Whiteboard: [fidefe-reusable-components] → [recomp]
Assignee: nobody → hjones
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d2fd226f891 Remove --brand-color-accent and --platform-color-accent tokens r=reusable-components-reviewers,desktop-theme-reviewers,dao,jules
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: