1866719 - Crash in [@ NSSSocketControl::~NSSSocketControl | NSSSocketControl::~NSSSocketControl | CommonSocketControl::Release]

Status: RESOLVED DUPLICATE of bug 1866006

(Core :: Security: PSM, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/d734f58c-7372-4215-add6-a1bcc0231127

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(!mFd) (NSSSocketControl must outlive its file descriptor!)

Top 10 frames of crashing thread:

0  xul.dll  NSSSocketControl::~NSSSocketControl  security/manager/ssl/NSSSocketControl.h:266
1  xul.dll  NSSSocketControl::~NSSSocketControl  security/manager/ssl/NSSSocketControl.h:265
2  xul.dll  CommonSocketControl::Release  security/manager/ssl/CommonSocketControl.cpp:28
2  xul.dll  NSSSocketControl::Release  security/manager/ssl/NSSSocketControl.h:25
3  xul.dll  mozilla::RefPtrTraits<nsITLSSocketControl>::Release  mfbt/RefPtr.h:54
3  xul.dll  nsCOMPtr<nsITLSSocketControl>::~nsCOMPtr  xpcom/base/nsCOMPtr.h:344
3  xul.dll  mozilla::net::nsSocketTransport::~nsSocketTransport  netwerk/base/nsSocketTransport2.cpp:703
4  xul.dll  mozilla::net::nsSocketTransport::Release  netwerk/base/nsSocketTransport2.cpp:2322
5  xul.dll  mozilla::RefPtrTraits<nsASocketHandler>::Release  mfbt/RefPtr.h:54
5  xul.dll  RefPtr<nsASocketHandler>::ConstRemovingRefPtrTraits<nsASocketHandler>::Release  mfbt/RefPtr.h:420

The crash spike detector picked this up over the weekend. Dana since you introduced this assertion could you please have a look?