1867055 - No caret is displayed.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Alice0775 White]

On latest autoland, the following bug appears on Windows10 and Ubuntu22.04. (Not tested on macOS).

Steps to reproduce:

1. Open data:text/html,<iframe src="data:text/html,<textarea>this is textarea</textarea>"</iframe>
2. Focus the textarea

OR

2. Open data:text/html,<iframe src="data:text/html,<div style='border:solid 1px black; height:100px;' contentEditable='true'>this is contentEditable</div>"</iframe>
3. Focus the contenteditable

Actual results:
No caret is displayed.

Expected results:
Caret should be displayed

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=42486b4cf0abed8107b66eab8bab88bde0fe8072&tochange=b72b6773b51448682d4a42ccfba6a6f5b0eeec8e

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yeah seems we should probably move the caret handling to EnterPresShell / LeavePresShell. Surprised no test caught comment 0...

Comment 2

[Sean Feng [:sefeng]]

Attachment: Bug 1867055 - Update mCaretFrame in nsDisplayListBuilder::EnterPresShell r=emilio

In bug 1860328, we updated the code to set mCaretFrame for the
root presShell, instead of getting the current focused pres shell.
Apparently this is problematic when the caret is in a sub document.
So instead, we use nsDisplayListBuilder::EnterPresShell to make
sure sub pres shells can also create the carets.

Comment 3

[Donal Meehan [:dmeehan]]

Setting 122 to Fixed and resolving, the regressor was backed out of autoland and never landed in central

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with the build from 1860328#c12 on Windows 10x64 and test cases from comment 0. No caret is displayed.
The issue is verified fixed with Firefox 122.0b7 on Windows 10x64, macOS 12 and Ubuntu 22. The caret is correctly displayed.