1867217 - Updating an old git-cinnabar from mach bootstrap doesn't work when it was placed there manually

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[[:sergesanspaille]]

It fails with the error

Would you like to run a few configuration steps to ensure Git is
optimally configured? (Yn): 
usage: git-cinnabar [-h] [--version [{cinnabar,module,helper}]] {hg2git,git2hg,data,fsck,upgrade,reclone,fetch,bundle,unbundle,rollback,python,download} ...
git-cinnabar: error: argument command: invalid choice: 'self-update' (choose from 'hg2git', 'git2hg', 'data', 'fsck', 'upgrade', 'reclone', 'fetch', 'bundle', 'unbundle', 'rollback', 'python', 'download')
Command '['/home/ssp/.mozbuild/git-cinnabar/git-cinnabar', 'self-update']' returned non-zero exit status 2.

the pre-existing git-cinnabar was 0.5.11 , looks like it doesn't have the self-update switch. removing the directory and bootstrapping again solves the issue, but not in the most elegant way

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1867217 - Change when we throw away old versions of git-cinnabar.

Comment 2

[Iulian Moraru]

Because the bot didn't comment when the patch landed on autoland I will leave this message with the revision from autoland:
https://hg.mozilla.org/integration/autoland/rev/dcab4b73233245a6be8d9c1acdbdd87ed93a495b

Comment 3

[Mike Hommey [:glandium]]

(to be fair: if git-cinnabar had been bootstrapped originally, the "has a .git directory" condition would have been true). Overall, the new version is more resilient.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dcab4b732332