1867297 - Remove the BLOCKED_PERMISSIONS from the AddonManager

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, task, P3)

Description

[Arturo Mejia [:amejia]]

More context can be found below:

https://github.com/mozilla-mobile/firefox-android/pull/4568#discussion_r1407723934

https://github.com/mozilla-mobile/firefox-android/blob/860162c33c8519b80b65351d040989c88835cf6b/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt#L134-L141

Comment 1

[Rob Wu [:robwu]]

The check is not strictly necessary. See my comments at bug 1759601.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1867297 - Remove the use of `BLOCKED_PERMISSIONS` (#4651)

Comment 3

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/439e2f88092aaf3035f9d1b48ea54ed9c41f0172
[main] Bug 1867297 - Remove the use of BLOCKED_PERMISSIONS

Comment 4

[William Durand [:willdurand]]

Hey Alex, could you please verify this bug?

Comment 5

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly for Android (122.0a1/Build #2015990855, fab78e74bf+, GV: 122.0a1-20231210093611).

To verify the fix, I created a custom collection with Video DownloadHelper (which requires the nativeMessaging permission) and attempted to install the add-on on both the latest Beta (which does not have the fix) and the latest Nightly (which has the fix). According to https://bugzilla.mozilla.org/show_bug.cgi?id=1759601#c3 , the add-on should fail to install on Beta but succeed on Nightly, which is what happens, confirming the fix.

Moreover, about:debugging on Nightly shows a log stating addons.webextension.{b9db16a4-6edc-47ec-a1f4-b86292ed211d} WARN Loading extension '{b9db16a4-6edc-47ec-a1f4-b86292ed211d}': Reading manifest: Invalid extension permission: nativeMessaging when installing the add-on.

Compared to the add-on installed on Desktop, the permissions tab for the add-on on Android also does not show/mention the “Exchange messages with programs other than Firefox”, which is the nativeMessaging permission.

Considering the above, the issue is fixed.