1867308 - The focus remain stuck the entire Firefox session after focusing any of the buttons from the Search OneOffs section while the Opt-In section is displayed at the bottom

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: focus stuck in oneOffSearch.mp4

[Affected versions]:

• Firefox Beta 121.0b4 - Build ID: 20231120154937
• Firefox Nightly 122.0a1 - Build ID: 20231129050021

[Affected Platforms]:

• Windows 10 x64
• Ubuntu 22.04 x64
• macOS 13.6

[Prerequisites]:

• Have a Firefox 121 or 122 en* build installed.
• Have the following prefs in the "about:config" page:
  -browser.search.region set to US;
  -browser.urlbar.quicksuggest.contextualOptIn set to true
  -browser.urlbar.quicksuggest.contextualOptIn.topPosition set to false

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Open click in the Address Bar.
3. Press the down arrow key until the "Not not" button is focused.
4. Open a new tab and click the Address Bar.
5. Observe the behavior.

[Expected result]:

• No buttons are focused.

[Actual result]:

• The "Not Now" button remains focused, and the focus cannot be dismissed.

[Regression]

• This issue is not reproducible with Firefox Beta 121.0b4. Using mozregression tools we have found the following:
  -Last good revision: 413cc418d2da5d2e324b2c5081e11214ac50f3fd
  -First bad revision: 5a9dc4e73f4690603070bfeefb4eac9b5260bbb7
  -Pushlog: Link

Based on this pushlog it seems that Bug 1866069 introduced this issue.

[Notes]:

• The following error is displayed after reaching the "Not Now" button:
  • handleEvent resource:///modules/UrlbarInput.sys.mjs:553 UrlbarController.sys.mjs:691:19
    TypeError: element is null19 UrlbarSearchOneOffs.sys.mjs:194:39
• The issue is NOT reproducible for the Opt-In section displayed at the top.
• THe issue is still reproducible even after the Opt-In section is dismissed. You need to restart the browser in order to lose focus.
• Attached is a screen recording of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1866069

:dao, since you are the author of the regressor, bug 1866069, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1867308 - Add null-check in #isQuickSuggestOptInElement. r=daleharvey

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8493fb875960
Add null-check in #isQuickSuggestOptInElement. r=daleharvey

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8493fb875960

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9366257 [details]
Bug 1867308 - Add null-check in #isQuickSuggestOptInElement. r=daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: Hopefully the last (based on current QA findings) issue we'll want to fix for the Firefox Suggest data collection opt-in experiment that we're going to run in 121, supports OKR 5.2. This bug affecting only half of the treatment branches might skew experiment results.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA found this, they have the steps, see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): one-liner null-check fix
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366257 [details]
Bug 1867308 - Add null-check in #isQuickSuggestOptInElement. r=daleharvey

Approved for 121.0b7.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0c0cb9e9377

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 121.0b7 (Build ID: 20231204092159) and the latest Nightly 122.0a1 (Build ID: 20231204091942) on Windows 10 x64, macOS 13.1 and Ubuntu 20.4 x64.

• The focus is no longer stuck after following the steps from comment 0.