1867360 - Require toplevel protocols to specify which process(es) they expect to be bound within

Assignee

Description

•

2 years ago

This would be done with an extended attribute on the IPDL actor which specifies which process the parent & child side of an actor is expected to be bound in, and then performs bind-time debug assertions that the binding process appears to be correct. This is not intended as a security mechanism, but rather as a documentation one to make things like auditing our IPDL actors easier.

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 1

•

2 years ago

Attached file Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=#ipc-reviewers!,decoder! — Details

Andrew McCreight [:mccr8]

Comment 2

•

2 years ago

I was curious about the distribution of the different process types (does having some kind of default make sense?) so I wrote an overengineered Python script to analyze the diff. Skipping changes to files with "/ipc/ipdl/test/" in the path it looks like this:

Parent process counts:
default 28, compositor 6, any 3, socket 3, gpu 3, vr 2, tab 1, rdd 1, utility 1

Child process counts:
anydom 12, default 8, tab 7, socket 7, any 4, utility 4, gmplugin 2, anychild 2, gpu 1, sandboxbroker 1

Combined parent+child process counts:
default anydom 7, default socket 7, default tab 4, default utility 4, compositor anydom 4, socket tab 3, gpu default 3, any any 2, default anychild 2, default any 1, default default 1, default gmplugin 1, tab gmplugin 1, rdd default 1, any anydom 1, compositor default 1, compositor any 1, vr default 1, vr gpu 1, utility default 1, default sandboxbroker 1

Andrew McCreight [:mccr8]

Comment 3

•

2 years ago

Attached file diff analyzer Python script — Details

Andrew McCreight [:mccr8]

Comment 4

•

2 years ago

It looks like "default" might be a nice default (no pun intended) for the parent process, but nothing for the child processes is miles ahead.

Andrew McCreight [:mccr8]

Comment 5

•

2 years ago

My other slightly cursed idea is that instead of defining a few magic values like anydom for process types, we could use a character like "+" as a union separator. + is allowed as a character in the IPDL strings, I think, but won't appear in a process type. So instead of writing ChildProc=anydom you could write ChildProc=default+tab . You could even allow ! to indicate negation and then instead of ChildProc=anychild, have ChildProc=!default. Maybe that's a bridge too far.

Phabricator Automation

Updated

•

2 years ago

Attachment #9366944 - Attachment description: Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=#ipc-reviewers!,decoder! → WIP: Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=#ipc-reviewers!,decoder!

Phabricator Automation

Updated

•

2 years ago

Attachment #9366944 - Attachment description: WIP: Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=#ipc-reviewers!,decoder! → Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=#ipc-reviewers!,decoder!

Pulsebot

Comment 6

•

2 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30210e0efac1 Require toplevel protocols to specify which processes they expect to be bound in, r=decoder,ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,aosmond,rkraesig,mccr8,kershaw

Atila Butkovits

Comment 7

•

2 years ago

Backed out for causing failures at PIPDLUnitTestChild.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/4bc62630a431fca569dfb1add5eee214dcdd091c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=30210e0efac13b607b202977b3a837351b4fe3e5&selectedTaskRun=KXfyOLUkRJaH29ITtaNxGQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=440612843&repo=autoland&lineNumber=12573

Flags: needinfo?(nika)

BugBot [:suhaib / :marco/ :calixte]

Comment 8

•

2 years ago

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:nika, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(nika)

Flags: needinfo?(choller)

Pulsebot

Comment 9

•

2 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c4ce17422de Require toplevel protocols to specify which processes they expect to be bound in, r=decoder,ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,aosmond,rkraesig,mccr8,kershaw

Natalia Csoregi [:nataliaCs]

Comment 10

•

2 years ago

Backed out for causing crashes on PRemoteQuotaObjectChild

[task 2024-01-08T21:10:43.790Z] 21:10:43  WARNING -  PROCESS-CRASH | MOZ_RELEASE_ASSERT(XRE_IsContentProcess()) [@ mozilla::dom::quota::PRemoteQuotaObjectChild::ActorAlloc] | dom/fs/test/xpcshell/test_fileSystemDirectoryHandle.js
[task 2024-01-08T21:10:43.790Z] 21:10:43     INFO -  Process type: main
[task 2024-01-08T21:10:43.791Z] 21:10:43     INFO -  Process pid: 14701
[task 2024-01-08T21:10:43.791Z] 21:10:43     INFO -  Mozilla crash reason: MOZ_RELEASE_ASSERT(XRE_IsContentProcess())
[task 2024-01-08T21:10:43.791Z] 21:10:43     INFO -  Crash dump filename: /tmp/xpc-other-0q484ugr/5b3e0fab-092d-fa26-9df0-870244eddf4e.dmp
[task 2024-01-08T21:10:43.791Z] 21:10:43     INFO -  Operating system: Linux
[task 2024-01-08T21:10:43.792Z] 21:10:43     INFO -                    4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018
[task 2024-01-08T21:10:43.792Z] 21:10:43     INFO -  CPU: amd64
[task 2024-01-08T21:10:43.792Z] 21:10:43     INFO -       family 6 model 85 stepping 7
[task 2024-01-08T21:10:43.792Z] 21:10:43     INFO -       2 CPUs
[task 2024-01-08T21:10:43.792Z] 21:10:43     INFO -  Linux Ubuntu 18.04 - bionic (Ubuntu 18.04.6 LTS)
[task 2024-01-08T21:10:43.793Z] 21:10:43     INFO -  Crash reason:  SIGSEGV / SEGV_MAPERR
[task 2024-01-08T21:10:43.793Z] 21:10:43     INFO -  Crash address: 0x0000000000000000
[task 2024-01-08T21:10:43.793Z] 21:10:43     INFO -  Crashing instruction: `mov dword [0x0], 0x33`
[task 2024-01-08T21:10:43.793Z] 21:10:43     INFO -  Memory accessed by instruction:
[task 2024-01-08T21:10:43.794Z] 21:10:43     INFO -    0. Address: 0x0000000000000000
[task 2024-01-08T21:10:43.794Z] 21:10:43     INFO -       Size: 4
[task 2024-01-08T21:10:43.794Z] 21:10:43     INFO -  Process uptime: not available
[task 2024-01-08T21:10:43.795Z] 21:10:43     INFO -  Thread 17 StreamTrans #1 (crashed)
[task 2024-01-08T21:10:43.795Z] 21:10:43     INFO -   0  libxul.so!mozilla::dom::quota::PRemoteQuotaObjectChild::ActorAlloc() [PRemoteQuotaObjectChild.cpp: : 51 + 0x0]
[task 2024-01-08T21:10:43.795Z] 21:10:43     INFO -       rax = 0x00007f4673922b1e    rdx = 0x00007f4668800020
[task 2024-01-08T21:10:43.795Z] 21:10:43     INFO -       rcx = 0x000055b399fe1478    rbx = 0x00007f4663589310
[task 2024-01-08T21:10:43.796Z] 21:10:43     INFO -       rsi = 0x0000000000000000    rdi = 0x00007f4663589310
[task 2024-01-08T21:10:43.796Z] 21:10:43     INFO -       rbp = 0x00007f46616fac60    rsp = 0x00007f46616fac50
[task 2024-01-08T21:10:43.796Z] 21:10:43     INFO -        r8 = 0x0000000000000000     r9 = 0x000000000001c100
[task 2024-01-08T21:10:43.796Z] 21:10:43     INFO -       r10 = 0x281250555d03f801    r11 = 0x0000000000000000
[task 2024-01-08T21:10:43.797Z] 21:10:43     INFO -       r12 = 0x00007f46638d5d20    r13 = 0x00007f46638d5d28
[task 2024-01-08T21:10:43.797Z] 21:10:43     INFO -       r14 = 0x00007f4663589310    r15 = 0x00007f46638d5ce8
[task 2024-01-08T21:10:43.797Z] 21:10:43     INFO -       rip = 0x00007f4678779af2
[task 2024-01-08T21:10:43.797Z] 21:10:43     INFO -      Found by: given as instruction pointer in context
[task 2024-01-08T21:10:43.798Z] 21:10:43     INFO -   1  libxul.so!mozilla::ipc::ActorLifecycleProxy::ActorLifecycleProxy(mozilla::ipc::IProtocol*) [ProtocolUtils.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 267]
[task 2024-01-08T21:10:43.798Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.798Z] 21:10:43     INFO -   2  libxul.so!mozilla::ipc::IProtocol::ActorConnected() [ProtocolUtils.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 561]
[task 2024-01-08T21:10:43.799Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.799Z] 21:10:43     INFO -   3  libxul.so!mozilla::ipc::IToplevelProtocol::OnIPCChannelOpened() [ProtocolUtils.h:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 517]
[task 2024-01-08T21:10:43.799Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.799Z] 21:10:43     INFO -   4  libxul.so!mozilla::ipc::MessageChannel::Open(mozilla::ipc::ScopedPort, mozilla::ipc::Side, nsID const&, nsISerialEventTarget*) [MessageChannel.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 687 + 0x6c]
[task 2024-01-08T21:10:43.799Z] 21:10:43     INFO -       rbx = 0x00007f46687d0e80    rbp = 0x00007f46616facf0
[task 2024-01-08T21:10:43.800Z] 21:10:43     INFO -       rsp = 0x00007f46616fac70    r12 = 0x00007f46638d5d20
[task 2024-01-08T21:10:43.800Z] 21:10:43     INFO -       r13 = 0x00007f46638d5d28    r14 = 0x00007f4663589310
[task 2024-01-08T21:10:43.800Z] 21:10:43     INFO -       r15 = 0x00007f46638d5ce8    rip = 0x00007f46768313a8
[task 2024-01-08T21:10:43.800Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.801Z] 21:10:43     INFO -   5  libxul.so!mozilla::ipc::IToplevelProtocol::Open(mozilla::ipc::ScopedPort, nsID const&, int, nsISerialEventTarget*) [ProtocolUtils.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 647 + 0x1d]
[task 2024-01-08T21:10:43.801Z] 21:10:43     INFO -       rbx = 0x0000000000000000    rbp = 0x00007f46616fad60
[task 2024-01-08T21:10:43.801Z] 21:10:43     INFO -       rsp = 0x00007f46616fad00    r12 = 0x00007f4663589388
[task 2024-01-08T21:10:43.801Z] 21:10:43     INFO -       r13 = 0x00007f46616fad08    r14 = 0x00007f46638f33c8
[task 2024-01-08T21:10:43.801Z] 21:10:43     INFO -       r15 = 0x00007f4663589310    rip = 0x00007f46768410b0
[task 2024-01-08T21:10:43.802Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.802Z] 21:10:43     INFO -   6  libxul.so!mozilla::ipc::UntypedEndpoint::Bind(mozilla::ipc::IToplevelProtocol*, nsISerialEventTarget*) [Endpoint.h:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 81 + 0x23]
[task 2024-01-08T21:10:43.802Z] 21:10:43     INFO -       rbx = 0x0000000000000000    rbp = 0x00007f46616fadc0
[task 2024-01-08T21:10:43.802Z] 21:10:43     INFO -       rsp = 0x00007f46616fad70    r12 = 0x00007f46616fad70
[task 2024-01-08T21:10:43.803Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46638f33c8
[task 2024-01-08T21:10:43.803Z] 21:10:43     INFO -       r15 = 0x00007f4663589310    rip = 0x00007f46765d6ec3
[task 2024-01-08T21:10:43.803Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.803Z] 21:10:43     INFO -   7  libxul.so!mozilla::ipc::Endpoint<mozilla::dom::quota::PRemoteQuotaObjectChild>::Bind(mozilla::dom::quota::PRemoteQuotaObjectChild*, nsISerialEventTarget*) [Endpoint.h:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 142]
[task 2024-01-08T21:10:43.803Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.804Z] 21:10:43     INFO -   8  libxul.so!mozilla::dom::quota::QuotaObject::Deserialize(mozilla::dom::quota::IPCQuotaObject&) [QuotaObject.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 68 + 0xc]
[task 2024-01-08T21:10:43.804Z] 21:10:43     INFO -       rbx = 0x00007f46616fae08    rbp = 0x00007f46616fadf0
[task 2024-01-08T21:10:43.804Z] 21:10:43     INFO -       rsp = 0x00007f46616fadd0    r12 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.805Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46638f33a0
[task 2024-01-08T21:10:43.805Z] 21:10:43     INFO -       r15 = 0x00007f4663589310    rip = 0x00007f4678753fb3
[task 2024-01-08T21:10:43.805Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.805Z] 21:10:43     INFO -   9  libxul.so!mozilla::dom::quota::FileRandomAccessStream::Deserialize(mozilla::ipc::RandomAccessStreamParams&) [FileStreams.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 152 + 0x7]
[task 2024-01-08T21:10:43.806Z] 21:10:43     INFO -       rbx = 0x0000000000000001    rbp = 0x00007f46616fae80
[task 2024-01-08T21:10:43.806Z] 21:10:43     INFO -       rsp = 0x00007f46616fae00    r12 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.806Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46614c11c0
[task 2024-01-08T21:10:43.806Z] 21:10:43     INFO -       r15 = 0x00007f46638f33a0    rip = 0x00007f467872bb2e
[task 2024-01-08T21:10:43.806Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.807Z] 21:10:43     INFO -  10  libxul.so!mozilla::ipc::DeserializeRandomAccessStream(mozilla::ipc::RandomAccessStreamParams&) [RandomAccessStreamUtils.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 64 + 0xb]
[task 2024-01-08T21:10:43.807Z] 21:10:43     INFO -       rbx = 0x00007f46616faf28    rbp = 0x00007f46616faec0
[task 2024-01-08T21:10:43.807Z] 21:10:43     INFO -       rsp = 0x00007f46616fae90    r12 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.807Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46638f3398
[task 2024-01-08T21:10:43.808Z] 21:10:43     INFO -       r15 = 0x00007f46614c1200    rip = 0x00007f46768460f8
[task 2024-01-08T21:10:43.808Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.808Z] 21:10:43     INFO -  11  libxul.so!mozilla::dom::FileSystemWritableFileStream::EnsureStream() [FileSystemWritableFileStream.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 926 + 0x12]
[task 2024-01-08T21:10:43.808Z] 21:10:43     INFO -       rbx = 0x00007f46638f32e0    rbp = 0x00007f46616faf60
[task 2024-01-08T21:10:43.809Z] 21:10:43     INFO -       rsp = 0x00007f46616faed0    r12 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.809Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46638f3398
[task 2024-01-08T21:10:43.809Z] 21:10:43     INFO -       r15 = 0x00007f46616fc270    rip = 0x00007f4677f3bbe3
[task 2024-01-08T21:10:43.809Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.810Z] 21:10:43     INFO -  12  libxul.so!mozilla::dom::FileSystemWritableFileStream::WriteImpl(nsCOMPtr<nsIInputStream>, mozilla::Maybe<unsigned long>)::$_0::operator()() const [FileSystemWritableFileStream.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 845]
[task 2024-01-08T21:10:43.810Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.810Z] 21:10:43     INFO -  13  libxul.so!mozilla::detail::ProxyFunctionRunnable<mozilla::dom::FileSystemWritableFileStream::WriteImpl(nsCOMPtr<nsIInputStream>, mozilla::Maybe<unsigned long>)::$_0, mozilla::MozPromise<long, nsresult, false> >::Run() [MozPromise.h:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 1690 + 0x8]
[task 2024-01-08T21:10:43.810Z] 21:10:43     INFO -       rbx = 0x00007f46614bf310    rbp = 0x00007f46616fb000
[task 2024-01-08T21:10:43.811Z] 21:10:43     INFO -       rsp = 0x00007f46616faf70    r12 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.811Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.811Z] 21:10:43     INFO -       r15 = 0x00007f46616fc270    rip = 0x00007f4677f48bee
[task 2024-01-08T21:10:43.811Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.811Z] 21:10:43     INFO -  14  libxul.so!mozilla::TaskQueue::Runner::Run() [TaskQueue.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 257 + 0x8]
[task 2024-01-08T21:10:43.812Z] 21:10:43     INFO -       rbx = 0x00007f46614bf4f0    rbp = 0x00007f46616fb0f0
[task 2024-01-08T21:10:43.812Z] 21:10:43     INFO -       rsp = 0x00007f46616fb010    r12 = 0x00007f46616fc2d0
[task 2024-01-08T21:10:43.812Z] 21:10:43     INFO -       r13 = 0x00007f46616fc270    r14 = 0x00007f46614bce00
[task 2024-01-08T21:10:43.812Z] 21:10:43     INFO -       r15 = 0x00007f46616fc270    rip = 0x00007f467614b7ea
[task 2024-01-08T21:10:43.813Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.813Z] 21:10:43     INFO -  15  libxul.so!nsThreadPool::Run() [nsThreadPool.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 341 + 0x8]
[task 2024-01-08T21:10:43.813Z] 21:10:43     INFO -       rbx = 0x00007f46687713a0    rbp = 0x00007f46616fb210
[task 2024-01-08T21:10:43.813Z] 21:10:43     INFO -       rsp = 0x00007f46616fb100    r12 = 0x0000000000000000
[task 2024-01-08T21:10:43.813Z] 21:10:43     INFO -       r13 = 0x00007f4668771438    r14 = 0x00007f46614bf4f0
[task 2024-01-08T21:10:43.814Z] 21:10:43     INFO -       r15 = 0x00007f46687713d0    rip = 0x00007f4676164759
[task 2024-01-08T21:10:43.814Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.814Z] 21:10:43     INFO -  16  libxul.so!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 1193 + 0x9]
[task 2024-01-08T21:10:43.814Z] 21:10:43     INFO -       rbx = 0x00007f46687c8460    rbp = 0x00007f46616fb330
[task 2024-01-08T21:10:43.814Z] 21:10:43     INFO -       rsp = 0x00007f46616fb220    r12 = 0x00007f46687713a0
[task 2024-01-08T21:10:43.815Z] 21:10:43     INFO -       r13 = 0x000001fb10572801    r14 = 0x00007f46616fb34f
[task 2024-01-08T21:10:43.815Z] 21:10:43     INFO -       r15 = 0x00007f46687c8560    rip = 0x00007f467615f2c4
[task 2024-01-08T21:10:43.815Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -  17  libxul.so!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 480 + 0xf]
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -       rbx = 0x0000000000000000    rbp = 0x00007f46616fb360
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -       rsp = 0x00007f46616fb340    r12 = 0x00007f46635ba1c8
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -       r13 = 0x0000000000000002    r14 = 0x00007f46616fb3f8
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -       r15 = 0x00007f46687c8460    rip = 0x00007f4676162eac
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.816Z] 21:10:43     INFO -  18  libxul.so!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [MessagePump.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 300 + 0x9]
[task 2024-01-08T21:10:43.817Z] 21:10:43     INFO -       rbx = 0x00007f46635bb280    rbp = 0x00007f46616fb3a0
[task 2024-01-08T21:10:43.817Z] 21:10:43     INFO -       rsp = 0x00007f46616fb370    r12 = 0x00007f46635ba1c8
[task 2024-01-08T21:10:43.817Z] 21:10:43     INFO -       r13 = 0x0000000000000002    r14 = 0x00007f46616fb3f8
[task 2024-01-08T21:10:43.817Z] 21:10:43     INFO -       r15 = 0x00007f46687c8460    rip = 0x00007f4676839437
[task 2024-01-08T21:10:43.818Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.819Z] 21:10:43     INFO -  19  libxul.so!MessageLoop::RunInternal() [message_loop.cc:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 370]
[task 2024-01-08T21:10:43.819Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.819Z] 21:10:43     INFO -  20  libxul.so!MessageLoop::RunHandler() [message_loop.cc:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 363]
[task 2024-01-08T21:10:43.819Z] 21:10:43     INFO -      Found by: inlining
[task 2024-01-08T21:10:43.819Z] 21:10:43     INFO -  21  libxul.so!MessageLoop::Run() [message_loop.cc:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 345 + 0xb]
[task 2024-01-08T21:10:43.820Z] 21:10:43     INFO -       rbx = 0x00007f46635ba1c0    rbp = 0x00007f46616fb3d0
[task 2024-01-08T21:10:43.820Z] 21:10:43     INFO -       rsp = 0x00007f46616fb3b0    r12 = 0x00007f46635ba1c8
[task 2024-01-08T21:10:43.820Z] 21:10:43     INFO -       r13 = 0x0000000000000002    r14 = 0x000000000000000e
[task 2024-01-08T21:10:43.820Z] 21:10:43     INFO -       r15 = 0x00007f46616fb3f8    rip = 0x00007f46767e8de5
[task 2024-01-08T21:10:43.821Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.821Z] 21:10:43     INFO -  22  libxul.so!nsThread::ThreadFunc(void*) [nsThread.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 370 + 0x7]
[task 2024-01-08T21:10:43.821Z] 21:10:43     INFO -       rbx = 0x00007f46635ba1c0    rbp = 0x00007f46616fb5d0
[task 2024-01-08T21:10:43.821Z] 21:10:43     INFO -       rsp = 0x00007f46616fb3e0    r12 = 0x00007f46635ba1c8
[task 2024-01-08T21:10:43.822Z] 21:10:43     INFO -       r13 = 0x0000000000000002    r14 = 0x000000000000000e
[task 2024-01-08T21:10:43.822Z] 21:10:43     INFO -       r15 = 0x00007f46616fb3f8    rip = 0x00007f467615ca94
[task 2024-01-08T21:10:43.822Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.822Z] 21:10:43     INFO -  23  libnspr4.so!_pt_root [ptthread.c:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 201 + 0x6]
[task 2024-01-08T21:10:43.822Z] 21:10:43     INFO -       rbx = 0x00007f4663597a60    rbp = 0x00007f46616fb620
[task 2024-01-08T21:10:43.823Z] 21:10:43     INFO -       rsp = 0x00007f46616fb5e0    r12 = 0x00007f4668770b30
[task 2024-01-08T21:10:43.823Z] 21:10:43     INFO -       r13 = 0x0000000000000002    r14 = 0x00007f46616fc700
[task 2024-01-08T21:10:43.823Z] 21:10:43     INFO -       r15 = 0x00007f46687422c0    rip = 0x00007f467cb5dea6
[task 2024-01-08T21:10:43.823Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.823Z] 21:10:43     INFO -  24  xpcshell!set_alt_signal_stack_and_start(PthreadCreateParams*) [pthread_create_interposer.cpp:9c4ce17422de3673aaef5e5023534e2ed8efc207 : 81 + 0x5]
[task 2024-01-08T21:10:43.824Z] 21:10:43     INFO -       rbx = 0x00007f4663597a60    rbp = 0x00007f46616fb6f0
[task 2024-01-08T21:10:43.824Z] 21:10:43     INFO -       rsp = 0x00007f46616fb630    r12 = 0x00007f467cb5dcb0
[task 2024-01-08T21:10:43.824Z] 21:10:43     INFO -       r13 = 0x0000000000000000    r14 = 0x00007f4663036000
[task 2024-01-08T21:10:43.824Z] 21:10:43     INFO -       r15 = 0x00007f46616fb660    rip = 0x000055b399f50df4
[task 2024-01-08T21:10:43.825Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.825Z] 21:10:43     INFO -  25  libpthread.so.0 + 0x76da
[task 2024-01-08T21:10:43.825Z] 21:10:43     INFO -       rbx = 0x0000000000000000    rbp = 0x0000000000000000
[task 2024-01-08T21:10:43.825Z] 21:10:43     INFO -       rsp = 0x00007f46616fb700    r12 = 0x00007f46616fb7c0
[task 2024-01-08T21:10:43.825Z] 21:10:43     INFO -       r13 = 0x0000000000000000    r14 = 0x00007f46638d4150
[task 2024-01-08T21:10:43.826Z] 21:10:43     INFO -       r15 = 0x00007f4663081d58    rip = 0x00007f467c7466db
[task 2024-01-08T21:10:43.826Z] 21:10:43     INFO -      Found by: call frame info
[task 2024-01-08T21:10:43.826Z] 21:10:43     INFO -  26  libc.so.6 + 0x121a3e
[task 2024-01-08T21:10:43.826Z] 21:10:43     INFO -       rsp = 0x00007f46616fb7c0    rip = 0x00007f4670486a3f
[task 2024-01-08T21:10:43.826Z] 21:10:43     INFO -      Found by: stack scanning

Natalia Csoregi [:nataliaCs]

Comment 11

•

2 years ago

Also crashing on PROCESS-CRASH | MOZ_RELEASE_ASSERT(XRE_IsContentProcess()) [@ mozilla::net::PSocketProcessBridgeChild::ActorAlloc] | dom/fs/test/xpcshell/test_fileSystemDirectoryHandle.js

Nika Layzell [:nika] (ni? for response)

Assignee

Comment 12

•

2 years ago

(In reply to Natalia Csoregi [:nataliaCs] from comment #11)

Also crashing on PROCESS-CRASH | MOZ_RELEASE_ASSERT(XRE_IsContentProcess()) [@ mozilla::net::PSocketProcessBridgeChild::ActorAlloc] | dom/fs/test/xpcshell/test_fileSystemDirectoryHandle.js

Despite the signature, this apepars to just be method de-duplication, as the stack is actually connected to PRemoteQuotaObjectChild. It's probably worth adding a message to the crash to make them distinct.

Flags: needinfo?(nika)

Pulsebot

Comment 13

•

2 years ago

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86e4ebdf315d Require toplevel protocols to specify which processes they expect to be bound in, r=decoder,ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,aosmond,rkraesig,mccr8,kershaw

Sandor Molnar[:smolnar]

Comment 14

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/86e4ebdf315d

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox123: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 123 Branch

Christian Holler (:decoder)

Updated

•

1 year ago

Flags: needinfo?(choller)

Tom Schuster

Updated

•

9 months ago

Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=#ipc-reviewers!,decoder! 2 years ago Nika Layzell [:nika] (ni? for response) 48 bytes, text/x-phabricator-request		Details \| Review
diff analyzer Python script 2 years ago Andrew McCreight [:mccr8] 2.09 KB, text/plain		Details

Bugzilla

Require toplevel protocols to specify which process(es) they expect to be bound within

Categories

(Core :: IPC, enhancement, P3)

Tracking

()

People

(Reporter: nika, Assigned: nika)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(2 files)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Updated

Updated

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Comment 11

Comment 12

Comment 13

Comment 14

Updated

Updated

Attachment

General

Description

File Name

Content Type