1867409 - Object does not adjust its size to the SVG data it currently refers to.

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[fuchsiahoney]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

In an HTML file, an object element can refer to a SVG file like this:

<object data="small.svg"></object>

with small.svg being:

<svg xmlns="http://www.w3.org/2000/svg" width="160" height="120">
<a href="large.svg">
<image href="small.jpg"/>
</a>
</svg>

and large.svg being:

<svg xmlns="http://www.w3.org/2000/svg" width="800" height="600">
<a href="small.svg">
<image href="large.jpg"/>
</a>
</svg>

Actual results:

The object element initially takes on the size of small.svg correctly, 160x120. Upon clicking the link in small.svg, the object grows to 300x150, and remains at that size even after clicking the link in large.svg

Expected results:

The object should initially be 160x120, grow to the size of large.svg, 800x600, after clicking the link in small.svg, and shrink to the size of small.svg, its initial size, after clicking the link in large.svg

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::SVG' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Robert Longson [:longsonr]]

Odd, seems like we should have fixed this in bug 1063073 That bug has a test: https://searchfox.org/mozilla-central/source/dom/svg/test/test_object-delayed-intrinsic-size.html

Comment 3

[fuchsiahoney]

If a border is added to the object, and the inner link is clicked over and over again quickly, the border alone will sometimes be the correct size for an instant, before being shrunken to 300x150.

Comment 4

[fuchsiahoney]

Attachment: test.html

Comment 5

[fuchsiahoney]

Attachment: small.jpg

Comment 6

[fuchsiahoney]

Attachment: large.jpg

Comment 7

[fuchsiahoney]

Attachment: small.svg

Comment 8

[fuchsiahoney]

Attachment: large.svg

Comment 9

[Robert Longson [:longsonr]]

Attachment: large.svg

Comment 10

[Robert Longson [:longsonr]]

Attachment: small.svg

Comment 11

[Robert Longson [:longsonr]]

Attachment: small.svg

Comment 12

[Robert Longson [:longsonr]]

Attachment: HTML file for the test case

Comment 13

[Robert Longson [:longsonr]]

Seems to be a race between the new frame creation and the old frame destruction. The new frame creation happens first and then the old frame destruction sets the size back to the default.

Old frame destruction doesn't happen till nsDocumentViewer::Show when the previous document viewer is destroyed.

Comment 14

[Robert Longson [:longsonr]]

Attachment: Bug 1867409 - Delay notifying our new frame size to the embedder until after the old frame has completed its destruction r=emilio

Comment 15

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=78ff71815d92e50d2f94fe2351f9b5e821de0e97

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tlouw, could you have a look please?

For more information, please visit BugBot documentation.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/da3ff672d8b2
https://hg.mozilla.org/integration/autoland/rev/cf8394609309
Delay notifying our new frame size to the embedder until after the old frame has completed its destruction r=emilio

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82e297ebe697
https://hg.mozilla.org/integration/autoland/rev/57b12324193d
Revert "Bug 1867409 - Delay notifying our new frame size to the embedder until after the old frame has completed its destruction r=emilio" as requested by longsonr because it requires a reland with some adjustements.

Comment 19

[Serban Stanca [:SerbanS]]

Reverted this as requested by longsonr because it requires a reland with some adjustements.

• Revert link

Comment 20

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=2b895e9bca2fbc047ac9acd547fe5284fd102137

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3e20adb2a1d
https://hg.mozilla.org/integration/autoland/rev/1a64b46759a1
Delay notifying our new frame size to the embedder until after the old frame has completed its destruction r=emilio

Comment 22

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1a64b46759a1