1867588 - Clicking outside a PDF's page no longer commits drawings

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Marco Castelluccio [:marco]]

Steps to reproduce the problem:

1. Draw something on top of a page
2. Click outside the page to commit the drawing

Before bug 1866850, clicking outside the page committed the drawing.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1866850

Comment 2

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Always give the focus to the ink editor when starting drawing (bug 1867588) (#17375)

Comment 3

[Daniel Bodea [:danibodea]]

I cannot verify this fix because I can't determine what the difference between an affected and an unaffected build is. calixte, can you explain what the bad behavior is and how the fix changed it? Thank you!

How I attempted to test:

1. Load a random PDF (like this)
2. Click the "Draw" button from the top right.
3. Draw something on top of a page
4. Click outside the page to commit the drawing (gray area at the left and right of the PDF content)
   Both before the fix (Nightly v122.0a1 from 2023-11-27) and after the fix (Nightly v123.0a1 from 2023-12-21):
   The drawing appears focused by a blue rectangle. At this point, the user can move it around on the PDF or resize it.

Comment 4

[Calixte Denizet (:calixte)]

I can reproduce the issue with a build from the 2023-11-29.
For your information the regressing patch is in nightly with build id 20231129050021 (see https://hg.mozilla.org/mozilla-central/rev/98d9150247ce).

Comment 5

[Daniel Bodea [:danibodea]]

I can reproduce the said issue in Nightly v122.0a1 from 2023-11-29: Drawing on a PDF and than clicking outside of the PDF page dows not commit the drawing, only after tapping ESC or clicking the "Draw" button again. The fix is confirmed in Nightly v124.0a1, Beta v123.0 (RC) and Release v122.0.1: When the user draws on a PDF and then clicks outside the PDF page, the drawing is committed, and it appears focused with a blue rectangle. The verification was performed on both Windows 10 and MacOS 11.