1867667 - Serialization of WindowProxy fails for out-of-process iframes

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As seen on https://github.com/w3c/webdriver-bidi/issues/418 we currently fail to correctly serialize the .contentWindow property of an OOP iframe. Due to that we return a plain object but not a WindowProxy remote value.

As example you can use that page to create an iframe with a cross-origin URL:
https://mathiasbynens.github.io/css-dbg-stories/iframe-navigations.html

When trying to serialize window.frames[0] an object is returned because we only check the class name. But given that this is a magic object this fails. Instead we need to run a check with Window.isInstance(value) to properly run this check here:

https://searchfox.org/mozilla-central/rev/d84469b005106c5ab0f65e283f71c1415ce76c54/remote/webdriver-bidi/RemoteValue.sys.mjs#922

Sasha, would you mind to take that? It's needed so that we can get rid of the Fission related preferences from Puppeteer for BiDi.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1867667 - [bidi] Use correct check to identify WindowProxy in the serialization.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1867667 - [wdspec] Add test cases for serialization of cross-origin iframes.

Depends on D195210

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f716db0179c3
[bidi] Use correct check to identify WindowProxy in the serialization. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ee79c48e48ea
[wdspec] Add test cases for serialization of cross-origin iframes. r=webdriver-reviewers,whimboo

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43477 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f716db0179c3
https://hg.mozilla.org/mozilla-central/rev/ee79c48e48ea

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot