1867674 - Always honor pref print.save_as_pdf.use_page_rule_size_as_paper_size.enabled

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1867674. Always honor pref print.save_as_pdf.use_page_rule_size_as_paper_size.enabled. r=alaskanemily

Until recently the only place that checked this pref was the Firefox front-end
code, and it communicated to use the CSS page size as the "paper" sheet size
for PDFs by setting nsIPrintSettings.usePageRuleSizeAsPaperSize. This was
expanded in bug 1866319 to make WPT also ask for the same behavior. However,
there are other places that are failing to ask for this.

Rather than play whack-a-mole to fix up the entry points to PDF printing, this
moves the pref check to the platform code.

The one situation that I'm not changing the pref to work in is when Firefox is
running ond Android. That's just because it's not currently clear to me what
the fallout is of Firefox on Android potentially creating PDFs with different
sheet sizes, and I don't want us to potentially deal with negative fallout as
we're finishing up the Gsuite work in December.

For now, I'm also refraining from removing
nsIPrintSettings.usePageRuleSizeAsPaperSize just in case we run into issues
(not very likely on non-Android) and want to temporarily restore the old
behavior.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f88e07194a25
Always honor pref print.save_as_pdf.use_page_rule_size_as_paper_size.enabled. r=AlaskanEmily

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f88e07194a25