1867705 - [wpt-sync] Sync PR 43463 - Fix erronous UA styles in lists-styles.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43463 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43463
Details from upstream follow.

Tim Nguyen <[e-mail]> wrote:

Fix erronous UA styles in lists-styles.html

ol should not support none / disc / circle / square list-style-type, only ul should support those.

Spec: https://html.spec.whatwg.org/#lists

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b2df69cfa69325b504da69c49effd61723b0b24

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1932 subtests

Status Summary

Firefox

OK : 1
PASS: 1917
FAIL: 15

Chrome

OK : 1
PASS: 1671
FAIL: 261

Safari

OK : 1
PASS: 1853
FAIL: 79

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /html/rendering/non-replaced-elements/lists/lists-styles.html [wpt.fyi]
  • <ul type="1"> - list-style-type: FAIL
  • <ul type="a" class="type-a"> - list-style-type: FAIL
  • <ul type="A" class="type-A"> - list-style-type: FAIL
  • <ul type="i" class="type-i"> - list-style-type: FAIL
  • <ul type="I" class="type-I"> - list-style-type: FAIL
  • <ol type="none"> - list-style-type: FAIL linked bug:Bug 1708370
  • <li type="none"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="NONE"> - list-style-type: FAIL linked bug:Bug 1708370
  • <li type="NONE"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="disc"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="DISC"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="circle"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="CIRCLE"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="square"> - list-style-type: FAIL linked bug:Bug 1708370
  • <ol type="SQUARE"> - list-style-type: FAIL linked bug:Bug 1708370

New Tests That Don't Pass

• /html/rendering/non-replaced-elements/lists/lists-styles.html [wpt.fyi]
  • <ul type="1"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ul type="a" class="type-a"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ul type="A" class="type-A"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ul type="i" class="type-i"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ul type="I" class="type-I"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="none"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <li type="none"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="NONE"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <li type="NONE"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="disc"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="DISC"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="circle"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="CIRCLE"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="square"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)
  • <ol type="SQUARE"> - list-style-type: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/982a34078a79
[wpt PR 43463] - Fix erronous UA styles in lists-styles.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/92450ca4e19a
[wpt PR 43463] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65118cfd65f8
[wpt PR 43463] - Fix erronous UA styles in lists-styles.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b42632c3ae4c
[wpt PR 43463] - Update wpt metadata, a=testonly

Comment 5

[Iulian Moraru]

Attachment: Bug 1867705 - revert expectations added in the last wptsync. r=jgraham,aryx

Comment 6

[Iulian Moraru]

Backed out - revert the expectations added here because they are causing wpt failures on lists-styles.html.

• Push with failures

• Failure log

• Backout link

Comment 7

[Iulian Moraru]

Attachment: Bug 1867705 - remove duplicate files in lists-styles.html.ini. r=aryx,jgraham,emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3227e410e202
remove duplicate files in lists-styles.html.ini. r=aryx,jgraham,emilio CLOSED TREE

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm not sure why I got involved here. Feel free to re-needinfo if I need to do something.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/65118cfd65f8
https://hg.mozilla.org/mozilla-central/rev/3227e410e202