1867730 - [wpt-sync] Sync PR 43465 - Revert "Dispatch close event when MessagePort is disentangled"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43465 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43465
Details from upstream follow.

Hiroki Nakagawa <[e-mail]> wrote:

Revert "Dispatch close event when MessagePort is disentangled"

This reverts commit 6a74d3d8049e1744b862757a73f90f3d7a5e08b0.

Reason for revert:
The tests newly added by the original CL are failing on
chrome_wpt_tests on the Linux Tests bot:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/138259/overview

Original change's description:

Dispatch close event when MessagePort is disentangled

We want to dispatch a close event when an entangled MessagePort is disconnected.
Given a pair of entangled ports, port1 and port2, if port2 is closed at any point,
a port1’s error handler is run.
So we can change an error handler to dispatch a close event.

The tests of close event are as follows:

1. port was explicitly closed.
2. owning document was destroyed.
3. owning document crashed.
4. port was garbage collected.

Design Doc:https://docs.google.com/document/d/1lXZU2Pk2ycitqj8aL9kxT2aauwXqpA0vJDUalkXA29Y
Explainer:https://github.com/fergald/explainer-messageport-close
HTML spec PR:https://github.com/whatwg/html/pull/9933

Bug: 1495616
Change-Id: I99f9f5a0d7cc63f0916da316ec666ba793215019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003089
Reviewed-by: Jeremy Roman \<[e-mail]>
Commit-Queue: Nonoka Muraki \<[e-mail]>
Reviewed-by: Ming-Ying Chung \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1231743}

Bug: 1495616
Change-Id: Ib697597d6ab70a9a7bfc41a67dfc647698024a64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/5075742
WPT-Export-Revision: 1367e75dc145263824d6a3136457b2d123306a8a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 43465 applied with additional changes from upstream: dd47f140612cef24b9e9c692e77b4d3aa5307279

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2e942149cc838223caae18807fd25631d6ca347

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 1 subtests

Status Summary

Firefox

OK : 5
PASS : 5
TIMEOUT: 4

Chrome

OK : 5
PASS : 4
FAIL : 1
TIMEOUT: 4

Safari

OK : 4
PASS : 2
FAIL : 2
TIMEOUT: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webmessaging/message-channels/close-event/close-event.tentative.any.worker.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Close event listener added with onclose must be called.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /webmessaging/message-channels/close-event/close-event.tentative.any.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Close event listener added with onclose must be called.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6cfda4a3399
[wpt PR 43465] - Revert "Dispatch close event when MessagePort is disentangled", a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/725faaf34b65
[wpt PR 43465] - Revert "Dispatch close event when MessagePort is disentangled", a=testonly

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/725faaf34b65