186778 - Define QT_NO_DEBUG for --disable-debug to prevent qt build failure because QT Headers define DEBUG

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[timeless]

nsDeviceContextSpecFactoryQT.cpp: In method
`nsDeviceContextSpecFactoryQT::nsDeviceContextSpecFactoryQT ()':
nsDeviceContextSpecFactoryQT.cpp:62: `mID' undeclared (first use this
function)
nsDeviceContextSpecFactoryQT.cpp:62: (Each undeclared identifier is
reported only once for each function it appears in.)
make[6]: *** [nsDeviceContextSpecFactoryQT.o] Error 1
make[6]: Leaving directory `/builds/qt/mozilla/gfx/src/qt'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/builds/qt/mozilla/gfx/src'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/builds/qt/mozilla/gfx'
make[3]: *** [tier_9] Error 2
make[3]: Leaving directory `/builds/qt/mozilla'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/builds/qt/mozilla'
make[1]: *** [build] Error 2
make[1]: Leaving directory `/builds/qt/mozilla'
make: *** [build] Error 2

smontagu and hendikins reported this and i reproduced it too. biesi and i
tracked it down to nsRegionQT.h including qregion.h which eventually includes
qglobal.h which conditionally defines define DEBUG:

#if !defined(QT_NO_DEBUG) && !defined(QT_DEBUG)
#  define QT_DEBUG                              // display debug messages
#  if !defined(QT_NO_COMPAT)                    // compatibility with Qt 2
#    if !defined(NO_DEBUG) && !defined(DEBUG)
#      if !defined(Q_OS_MACX)                   // clash with MacOS X headers
#        define DEBUG

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

-> me, I have a patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 110131 [details] [diff] [review]
patch

r=cls

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1144; previous revision: 1.1143
done