1868087 - <ol type=disc> should have no effect per spec (and interop with Chrome/Safari)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Simon Pieters [:zcorpan]]

See https://github.com/whatwg/html/issues/9967

Spec https://html.spec.whatwg.org/#lists
Tests https://wpt.fyi/results/html/rendering/non-replaced-elements/lists/lists-styles.html?label=master&label=experimental&aligned&q=firefox%3Afail

We fail these tests:

<ul type="1"> - list-style-type
<ul type="a" class="type-a"> - list-style-type
<ul type="A" class="type-A"> - list-style-type
<ul type="i" class="type-i"> - list-style-type
<ul type="I" class="type-I"> - list-style-type
<ol type="none"> - list-style-type
<li type="none"> - list-style-type
<ol type="NONE"> - list-style-type
<li type="NONE"> - list-style-type
<ol type="disc"> - list-style-type
<ol type="DISC"> - list-style-type
<ol type="circle"> - list-style-type
<ol type="CIRCLE"> - list-style-type
<ol type="square"> - list-style-type
<ol type="SQUARE"> - list-style-type

At first I thought this was implemented in html.css but I didn't find relevant rules there. I guess it's in https://searchfox.org/mozilla-central/source/dom/html/HTMLSharedListElement.cpp

Comment 1

[Simon Pieters [:zcorpan]]

Not in the wpt tests yet but we also support <ol type="lower-roman"> which isn't per spec. https://software.hixie.ch/utilities/js/live-dom-viewer/saved/12192

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yeah presumably we need to split this codepath into one for <ol> and one for <ul>:

https://searchfox.org/mozilla-central/rev/68b1b0041a78abd06f19202558ccc4922e5ba759/dom/html/HTMLSharedListElement.cpp#28-45,51-56

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1868087 - Make <ol/ul/li type> match the spec. r=zcorpan

Other browsers seem to follow the spec to the letter, so do the same.

The list-styles.html test is marked as failing, but that's because it
hasn't been synced yet.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8de8a788dfa1
Make <ol/ul/li type> match the spec. r=zcorpan

Comment 5

[Simon Pieters [:zcorpan]]

For dev-doc-needed:

• <ol type=none/disc/circle/square> no longer work (these are only valid for ul).
• <ul type=1/a/A/i/I> no longer work (these are only valid for ol).
• The non-standard values decimal, lower-roman, upper-roman, lower-alpha, upper-alpha for the type attribute on ol, ul, li elements no longer work.

This change makes us conform to the HTML standard and should match WebKit and Chromium.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8de8a788dfa1

Comment 7

[Dave Letorey]

• Firefox 122 release PR