Closed Bug 1868087 Opened 5 months ago Closed 5 months ago

<ol type=disc> should have no effect per spec (and interop with Chrome/Safari)

Categories

(Core :: Layout, defect)

defect

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: zcorpan, Assigned: emilio)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

See https://github.com/whatwg/html/issues/9967

Spec https://html.spec.whatwg.org/#lists
Tests https://wpt.fyi/results/html/rendering/non-replaced-elements/lists/lists-styles.html?label=master&label=experimental&aligned&q=firefox%3Afail

We fail these tests:

<ul type="1"> - list-style-type
<ul type="a" class="type-a"> - list-style-type
<ul type="A" class="type-A"> - list-style-type
<ul type="i" class="type-i"> - list-style-type
<ul type="I" class="type-I"> - list-style-type
<ol type="none"> - list-style-type
<li type="none"> - list-style-type
<ol type="NONE"> - list-style-type
<li type="NONE"> - list-style-type
<ol type="disc"> - list-style-type
<ol type="DISC"> - list-style-type
<ol type="circle"> - list-style-type
<ol type="CIRCLE"> - list-style-type
<ol type="square"> - list-style-type
<ol type="SQUARE"> - list-style-type

At first I thought this was implemented in html.css but I didn't find relevant rules there. I guess it's in https://searchfox.org/mozilla-central/source/dom/html/HTMLSharedListElement.cpp

Not in the wpt tests yet but we also support <ol type="lower-roman"> which isn't per spec. https://software.hixie.ch/utilities/js/live-dom-viewer/saved/12192

Assignee: nobody → emilio

Other browsers seem to follow the spec to the letter, so do the same.

The list-styles.html test is marked as failing, but that's because it
hasn't been synced yet.

Attachment #9366798 - Attachment description: Bug 1868087 - Make <ol type> and <ul type> match the spec. r=zcorpan → Bug 1868087 - Make <ol/ul/li type> match the spec. r=zcorpan
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8de8a788dfa1
Make <ol/ul/li type> match the spec. r=zcorpan

For dev-doc-needed:

  • <ol type=none/disc/circle/square> no longer work (these are only valid for ul).
  • <ul type=1/a/A/i/I> no longer work (these are only valid for ol).
  • The non-standard values decimal, lower-roman, upper-roman, lower-alpha, upper-alpha for the type attribute on ol, ul, li elements no longer work.

This change makes us conform to the HTML standard and should match WebKit and Chromium.

Keywords: dev-doc-needed
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: