If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

console output for overlapping row and colspans

NEW
Unassigned

Status

()

Core
Layout: Tables
P4
normal
15 years ago
8 years ago

People

(Reporter: Bernd, Unassigned)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
timeless and biesi pressure me to issue a console message if a row and a colspan
overlap. I dont see a big win from this, but maybe they see or somenody else can
explain me in the bug why this is a good thing.
(Reporter)

Comment 1

15 years ago
Created attachment 110148 [details] [diff] [review]
patch
(Reporter)

Comment 2

15 years ago
maybee we should even remove the assertion in fabour of the console message
               NS_ASSERTION(PR_FALSE, "invalid overlap");
this should be NS_NOTREACHED("invalid overlap")

Also - if there are reasons other than invalid HTML, I would leave the assertion
in. If not, I would remove it.

just my opinion...
My 2 cents:

1)  This message would be useful in debugging web pages (including mozilla QA)
2)  The assertion should only fire if someone in Mozilla code made a
    mistake.... we should not be asserting just because we encounter invalid
    markup.
3)  The console message should be localized if we do this.
4)  It would be nice to include the URI of the page in the warning (and make it
    a real warning, not a string message) if the cell map has access to this
    information.
OS: Windows 98 → All
Hardware: PC → All

Updated

15 years ago
Priority: -- → P4
Target Milestone: --- → Future

Comment 5

13 years ago
Bernd, you asked me to ping you if I find another of your "forgotten" patches. 
What about this one, is there still any interest in getting a console message 
for these authoring errors?
Assignee: layout.tables → nobody
QA Contact: amar → layout.tables
You need to log in before you can comment on or make changes to this bug.