186809 - console output for overlapping row and colspans

Status: NEW

(Core :: Layout: Tables, defect, P4)

Description

[Bernd]

timeless and biesi pressure me to issue a console message if a row and a colspan
overlap. I dont see a big win from this, but maybe they see or somenody else can
explain me in the bug why this is a good thing.

Comment 1

[Bernd]

Attachment: patch

Comment 2

[Bernd]

maybee we should even remove the assertion in fabour of the console message

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

               NS_ASSERTION(PR_FALSE, "invalid overlap");
this should be NS_NOTREACHED("invalid overlap")

Also - if there are reasons other than invalid HTML, I would leave the assertion
in. If not, I would remove it.

just my opinion...

Comment 4

[Boris Zbarsky [:bzbarsky]]

My 2 cents:

1)  This message would be useful in debugging web pages (including mozilla QA)
2)  The assertion should only fire if someone in Mozilla code made a
    mistake.... we should not be asserting just because we encounter invalid
    markup.
3)  The console message should be localized if we do this.
4)  It would be nice to include the URI of the page in the warning (and make it
    a real warning, not a string message) if the cell map has access to this
    information.

Comment 5

[Erik Fabert]

Bernd, you asked me to ping you if I find another of your "forgotten" patches. 
What about this one, is there still any interest in getting a console message 
for these authoring errors?