1868250 - runxpcshelltests can dead-hang when http2 server doesn't terminate as expected

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Mike Hommey [:glandium]]

runxpcshelltests.py has the same problem as was found in mozserve/servers.py.
See https://phabricator.services.mozilla.com/D195207 for details.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1868250 - Don't stop reading from the pipe when the process is dead.

When the http2 server prints a bunch of stuff and dies, the loop doesn't
actually have the time to read multiple lines before poll returns
something, breaking the loop... leaving the log without possibly vital
information.

Unfortunately, since killing the process in stop can also lead to
the threads being blocked on readline (see bug 1863675), we also need to
stop joining the threads. If the process terminates normally, the loop
will break itself when the pipe returns nothing, and the threads will
exit on their own.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed4b5c2701f
Don't stop reading from the pipe when the process is dead. r=releng-reviewers,ahal

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fed4b5c2701f