1868303 - Fix clippy warnings in glean/api/src/ffi/macros.rs

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

toolkit/components/glean/api/src/ffi/macros.rs
  187:12  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments
 (clippy)
  188:15  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments
 (clippy)
  189:21  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments
 (clippy)
  190:21  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments
 (clippy)
  242:12  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments (clippy)
  243:15  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments (clippy)
  244:21  warning  using tabs in doc comments is not recommended  clippy::tabs_in_doc_comments (clippy)

Links to the code:
https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/toolkit/components/glean/api/src/ffi/macros.rs#187-192

To run clippy:

./mach lint -l clippy toolkit/components/glean/api/src/ -W -v    

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[The_Dunno]

Attachment: Bug 1868303 - Fix clippy warnings in glean/api/src/ffi/macros.rs: Removed tabs in comments.r=Chris H-C

Comment 2

[The_Dunno]

Fixed this bug by removing the tabs in the comments. This is my first bug. I hope I did everything right:

• I fixed the bug.
• I did all the tests.
• I ran hg commit with the reviewer set to somebody who appeared lots in the hg log.
• I ran moz-phab

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 4

[gasc]

Attachment: Bug 1868303 - Fix clippy warnings in glean/api/src/ffi/macros.rs. r=janerik

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from reviewers who are inactive or resigned from the review:

ID	Title	Author	Reviewer Status
D212933	Bug 1868303 - Fix clippy warnings in glean/api/src/ffi/macros.rs: Removed tabs in comments.r=Chris H-C	groundsweepr	chutten: Resigned from review
			janerik: Resigned from review

:groundsweepr, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4aa9dc712e1
Fix clippy warnings in glean/api/src/ffi/macros.rs. r=janerik DONTBUILD

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b4aa9dc712e1