Closed Bug 1868425 Opened 2 years ago Closed 1 year ago

Update moz-card's status in Storybook

Categories

(Toolkit :: UI Widgets, task, P3)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: tgiles, Assigned: gzyfqh, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [recomp] [lang=js])

Attachments

(1 file)

Once moz-card is "stable enough", we need to update the status of the component in Storybook. I'm not sure how we define "stable enough" though in this case.

Whiteboard: [fidefe-reusable-components] → [recomp]

Talking with the Recomp team, we think this component is "stable enough" now. While there are still enhancements to add, moz-card is being used in various places in Firefox without issue. So we should go ahead and update the status of the component in Storybook.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
  3. Start working on this bug.
  4. Build your change with mach build and test your change with mach storybook. Also check your changes for adherence to our style guidelines by using mach lint.
    • The status should be correctly updated in Storybook, showing the "Stable" badge instead of the "In Development" badge.
  5. Submit the patch (including an automated test, if applicable) for review. Mark the mentor as a reviewer so they will get an email to come look at your code.
  6. After a series of reviews and changes to your patch, your mentor will push it to autoland.
  7. ...now you get to think about what kind of bug you'd like to work on next.
    Let us know what you're interested in and we can help you find your next bug to work on!
Mentor: akulyk
Keywords: good-first-bug
Whiteboard: [recomp] → [recomp] [lang=js]

According to the Recomp team, the component is now widely used and
stable enough.

Assignee: nobody → gzyfqh
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab92fe0d616d Update moz-card's status in Storybook to stable r=akulyk,reusable-components-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: