Closed
Bug 1868425
Opened 2 years ago
Closed 1 year ago
Update moz-card's status in Storybook
Categories
(Toolkit :: UI Widgets, task, P3)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
137 Branch
| Tracking | Status | |
|---|---|---|
| firefox137 | --- | fixed |
People
(Reporter: tgiles, Assigned: gzyfqh, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [recomp] [lang=js])
Attachments
(1 file)
Once moz-card is "stable enough", we need to update the status of the component in Storybook. I'm not sure how we define "stable enough" though in this case.
Updated•2 years ago
|
Updated•2 years ago
|
Whiteboard: [fidefe-reusable-components] → [recomp]
| Reporter | ||
Comment 1•1 year ago
|
||
Talking with the Recomp team, we think this component is "stable enough" now. While there are still enhancements to add, moz-card is being used in various places in Firefox without issue. So we should go ahead and update the status of the component in Storybook.
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help.
This will tell others that you're working on the next steps. - Download and build the Firefox source code
- If you have any problems, please ask on Element/Matrix in the
#introductionchannel. They're there to help you get started.
- If you have any problems, please ask on Element/Matrix in the
- Start working on this bug.
- You will need to update the "in-development" string in moz-card.stories.mjs to "stable"
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for the assigned mentor. Also, you can reacy the relevant folks on the
#reusable-componentschannel on Element/Matrix most hours of most days.
- Build your change with
mach buildand test your change withmach storybook. Also check your changes for adherence to our style guidelines by usingmach lint.- The status should be correctly updated in Storybook, showing the "Stable" badge instead of the "In Development" badge.
- Submit the patch (including an automated test, if applicable) for review. Mark the mentor as a reviewer so they will get an email to come look at your code.
- How to Submit a Patch
- This is when the bug will be assigned to you.
- After a series of reviews and changes to your patch, your mentor will push it to autoland.
- If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
- Your code will soon be shipping to Firefox users worldwide!
- ...now you get to think about what kind of bug you'd like to work on next.
Let us know what you're interested in and we can help you find your next bug to work on!
According to the Recomp team, the component is now widely used and
stable enough.
Updated•1 year ago
|
Assignee: nobody → gzyfqh
Status: NEW → ASSIGNED
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab92fe0d616d
Update moz-card's status in Storybook to stable r=akulyk,reusable-components-reviewers
Comment 5•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox137:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•