1868436 - [css-properties-values-api] Registered property dependency cycle values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Shin[:dshin]]

Attachment: Mimimum Reproducible Case

STR: Load attached test case, check console output
Expected: If .ancestor is commented out:

#foo
  --reg-1 3px 
  --reg-2 15px
  --reg-3 18px
#bar
  --reg-1 3px
  --reg-2 1px
  --reg-3 27px

If .ancestor is not commented out:

#foo
  --reg-1 5px 
  --reg-2 20px 
  --reg-3 25px 
#bar
  --reg-1 5px 
  --reg-2 1px 
  --reg-3 32px

Actual:
If .ancestor is commented out:

#foo 
  --reg-1 
  --reg-2 
  --reg-3 27px 
#bar 
  --reg-1 
  --reg-2 1px 
  --reg-3 

If .ancestor is not commented out:

#foo 
  --reg-1 
  --reg-2 
  --reg-3 32px 
#bar 
  --reg-1 
  --reg-2 1px 
  --reg-3 

So currently we behave as if they're guaranteed-invalid values.

This is incorrect, as variables directly in the dependency cycle resolve to be invalid at compute time, which, for registered custom properties with non-universal syntax, resolves the computed value as if unset, instead of resolving to guaranteed-invalid value, so properties referring to it (Unless they're part of a cycle) use those computed values.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1868436: Registered non-universal property dependency cycle resolve as if unset. r=emilio,zrhoffman

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24080912beec
Registered non-universal property dependency cycle resolve as if unset. r=zrhoffman

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/24080912beec