Closed Bug 1868443 Opened 1 year ago Closed 1 year ago

Searching open tabs in Firefox View takes 6 seconds

Categories

(Firefox :: Firefox View, defect, P1)

defect

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: jrmuizel, Assigned: kcochrane)

References

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

I have a lot of tabs. When I try typing in the search field with browser.firefox-view.search.enabled=true, the browser hangs for 6 seconds.

https://share.firefox.dev/47KBnho

Jeff, do you have the browser.firefox-view.virtual-list.enabled pref set to true?

Flags: needinfo?(jmuizelaar)

Virtual list had not made it into my Nightly yet so the pref wasn't set to true.

Flags: needinfo?(jmuizelaar)

Here's a new profile with browser.firefox-view.virtual-list.enabled=true:
https://share.firefox.dev/3GudZbZ

It's still very slow

And you're working with ~2500 open tabs right?

It looks about ~2900. I also noticed that <virutal-list> element has a childElementCount of 2929. Is this expected with the virtual list?

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)

It looks about ~2900. I also noticed that <virutal-list> element has a childElementCount of 2929. Is this expected with the virtual list?

I noticed a bit of jank even with ~500 tabs so we'll look into this. Kelly, can you weigh in on this question about the virtual list?

Flags: needinfo?(kcochrane)
Priority: -- → P1
Whiteboard: [fidefe-firefox-view]

It looks like it’s because we switched from using window.innerHeight to window.windowUtils.getRootBounds().height when calculating maxRenderCountEstimate in virtual-list here:
https://searchfox.org/mozilla-central/source/browser/components/firefoxview/fxview-tab-list.mjs#690,707

Investigating ways of correcting this now. Thanks for flagging, [:jrmuizel]!

Assignee: nobody → kcochrane
Flags: needinfo?(kcochrane)
Status: NEW → ASSIGNED
Depends on: 1868657
Pushed by kcochrane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6bb70e7a0a5 Update calculation for viewport height in Firefox View r=fxview-reviewers,sclements

Jeff, this has landed to autoland. When you get the chance, can you let us know if that reduced the lag/jank you were seeing with the virtual-list enabled?

Flags: needinfo?(jmuizelaar)
See Also: → 1868847
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

(In reply to Kelly Cochrane [:kcochrane] from comment #10)

Jeff, this has landed to autoland. When you get the chance, can you let us know if that reduced the lag/jank you were seeing with the virtual-list enabled?

Yes, that improves search speed considerably.

Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: