Searching open tabs in Firefox View takes 6 seconds
Categories
(Firefox :: Firefox View, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: kcochrane)
References
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
I have a lot of tabs. When I try typing in the search field with browser.firefox-view.search.enabled=true, the browser hangs for 6 seconds.
Comment 1•1 year ago
|
||
Jeff, do you have the browser.firefox-view.virtual-list.enabled
pref set to true?
Updated•1 year ago
|
Reporter | ||
Comment 2•1 year ago
|
||
Virtual list had not made it into my Nightly yet so the pref wasn't set to true.
Reporter | ||
Comment 3•1 year ago
|
||
Here's a new profile with browser.firefox-view.virtual-list.enabled=true:
https://share.firefox.dev/3GudZbZ
It's still very slow
Comment 4•1 year ago
|
||
And you're working with ~2500 open tabs right?
Reporter | ||
Comment 5•1 year ago
|
||
It looks about ~2900. I also noticed that <virutal-list> element has a childElementCount of 2929. Is this expected with the virtual list?
Comment 6•1 year ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
It looks about ~2900. I also noticed that <virutal-list> element has a childElementCount of 2929. Is this expected with the virtual list?
I noticed a bit of jank even with ~500 tabs so we'll look into this. Kelly, can you weigh in on this question about the virtual list?
Updated•1 year ago
|
Assignee | ||
Comment 7•1 year ago
|
||
It looks like it’s because we switched from using window.innerHeight
to window.windowUtils.getRootBounds().height
when calculating maxRenderCountEstimate
in virtual-list here:
https://searchfox.org/mozilla-central/source/browser/components/firefoxview/fxview-tab-list.mjs#690,707
Investigating ways of correcting this now. Thanks for flagging, [:jrmuizel]!
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 8•1 year ago
|
||
Assignee | ||
Comment 10•1 year ago
|
||
Jeff, this has landed to autoland. When you get the chance, can you let us know if that reduced the lag/jank you were seeing with the virtual-list enabled?
Comment 11•1 year ago
|
||
bugherder |
Reporter | ||
Comment 12•1 year ago
|
||
(In reply to Kelly Cochrane [:kcochrane] from comment #10)
Jeff, this has landed to autoland. When you get the chance, can you let us know if that reduced the lag/jank you were seeing with the virtual-list enabled?
Yes, that improves search speed considerably.
Description
•