1868488 - aboutwelcome code missing eslint config overrides

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

The one I initially noticed is over here - we need to add the aboutwelcome directory to the files array. I didn't take a close look, but probably there are some other overrides in there that apply to newtab but should also apply to aboutwelcome, or there might be some that apply to specific files that were moved to aboutwelcome.

Comment 1

[Shane Hughes [:aminomancer]]

We're also missing aboutwelcome from .stylelintrc.js

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1863400

:mconley, since you are the author of the regressor, bug 1863400, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Shane Hughes [:aminomancer]]

We don't mind triaging this on Monday as normal, though @mconley if you're still working on these bugs feel free to pick this one up.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1868488 - Add aboutwelcome to the same ESLint directory overrides as newtab. r?aminomancer!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks, aminomancer. I went through the .eslintrc.js, and I think this one rule is the only one that applies.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce3d8ad39610
Add aboutwelcome to the same ESLint directory overrides as newtab. r=aminomancer

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ce3d8ad39610