1868527 - "Site not working?" button should not be shown when the new webcompat reporter is enabled

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P2)

Description

[Daniel Bodea [:danibodea]]

Note

• We’ve found that in certain situations the Protections Panel shows both the “Report a broken site…” button and the “Site not working?” button. Considering that this might be somewhat intended, I imagine how this could cause some confusion. The dialog that opens when accessing the “Site not working?” button is tied to ETP/trackers.

Found in

• Beta v121.0b6

Affected versions

• Nightly v122.0a1
• Beta v121.0b6

Tested platforms

• Affected platforms: All
• Unaffected platforms: -

Steps to reproduce

1. Make sure the new webcompat reporter is enabled:
   ui.new-webcompat-reporter.enabled = true
2. Load reddit.com
3. Allow cookies
4. Open Protections Panel (shield icon from URL bar)

Expected result

• Only “Report a broken site…” and is displayed.

Actual result

• Notice that both “Report a broken site…” and the “Site not working?” buttons are being displayed.

Regression range

• Not a regression but an issue since the implementation of the new webcompat reporter.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Protections UI' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Emma Zühlcke [:emz]]

Tom, I remember we talked about this issue. We agreed on hiding the old reporter if the new one is showing. Would you like to take this bug?

Comment 3

[Thomas Wisniewski [:twisniewski]]

It's on my shortlist of tasks, yes. We still wish to hide "Site not working" entirely, yes? (Despite it having different UX to guide the user to disable ETP?)

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1868527 - hide 'Site not working?' from the protections panel when the 'Report Broken Site' feature is active; r?pbz

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b74a3cc13f8a
hide 'Site not working?' from the protections panel when the 'Report Broken Site' feature is active; r=pbz

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b74a3cc13f8a

Comment 7

[Daniel Bodea [:danibodea]]

I have verified this implementation in Nightly v122.0a1. The "Site not working?" button is no longer displayed in the Permissions Panel, however, Beta v121.0 (RC) still reproduced the the issue. The testing was performed on Windows 10, MacOS 11, and Ubuntu 22. Thank you.