1868567 - Firefox View longer searched terms will overflow the message box

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: fx view search long string.png

Found in

• Firefox 122.0a1

Affected versions

• Firefox 122.0a1

Tested platforms

• Affected platforms: macOS 14.1.2, Windows 11, Ubuntu 22.04

Preconditions

• Have browser.firefox-view.search.enabled set to true

Steps to reproduce

1. Launch Firefox and access Firefox View
2. Open any of the sections available besides Open Tabs
3. Focus search and type any word/website
4. Copy the typed word and paste it multiple times inside search
5. Look at the "No results for ..." message in the page

Expected result

• The searched string is kept inside the message box

Actual result

• The searched string will overflow the message box

Additional notes

• The issue can be seen in the attachment
• Strangely enough, if a website link is pasted multiple times, it will not behave the same as a manually typed string
• The issue is not reproducible in Open Tabs

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1868567 - Firefox View longer searched terms will overflow the message box r?#fxview-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02b6f4b61069
Firefox View longer searched terms will overflow the message box r=fxview-reviewers,sclements

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/02b6f4b61069

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jsudiaman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Donal Meehan [:dmeehan]]

Firefox view search is not enabled in Fx122

Comment 6

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the message boxes are no longer overflowed by inputting longer strings on Firefox 123.0a1 (2024-01-02). Tests were performed on macOS 13.6.3, Ubuntu 22.04 and Windows 11.

On another note it seems that History page has a different behavior than the other sections, so when a longer string is pasted multiple times, both the search result box and the import history message gets stretched out of view to the right. Here is an attachment with the behavior. Should I file a new bug for this Jonathan ?

Comment 7

[Jonathan Sudiaman [:jsudiaman]]

(In reply to Catalin Sasca, Desktop QA [:csasca] from comment #6)

Verified that the message boxes are no longer overflowed by inputting longer strings on Firefox 123.0a1 (2024-01-02). Tests were performed on macOS 13.6.3, Ubuntu 22.04 and Windows 11.

On another note it seems that History page has a different behavior than the other sections, so when a longer string is pasted multiple times, both the search result box and the import history message gets stretched out of view to the right. Here is an attachment with the behavior. Should I file a new bug for this Jonathan ?

Yes, please file a new bug so that we can triage it.