1868626 - In Thunderbird 115 and later, Options > Quote Message does not work when composing a reply from a message opened in a new tab

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[EarlgreyTea]

User-Agent:
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:115.0) Gecko/20100101 Thunderbird/115.5.1
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:122.0) Gecko/20100101 Firefox/122.0 Thunderbird/122.0a1

Steps to Reproduce:

1. Start Thunderbird and open a message in a new tab.
2. Click the reply button on the opened message.
3. Select "Options > Quote Message" in the compose window.

Actual results:

The message is not quoted and there is no change to the window. The same result occurs when opening the message in a new window and then composing a reply.
It works fine when I compose a reply directly from a message selected in the message list.

Expected results:

The message will be quoted by "Options > Quote Message".

Additional Information:

The following error appears in the error console.

An error occurred executing the cmd_quoteMessage command: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgCompose.quoteMessage]" 
nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://messenger/content/messengercompose/MsgComposeCommands.js :: QuoteSelectedMessage :: line 1568"  data: no] globalOverlay.js:102:13

Regression range:
first bad build: 569a4baf6d46d2a4fec772d11c2ab6c04fd8365d (2023-05-18 23:55:35.469000)
pushlog_url: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=abb2293802ec3ab2a9924b6ecbfda2367568b5a4&tochange=569a4baf6d46d2a4fec772d11c2ab6c04fd8365d

Comment 1

[Francesco]

Confirming what you wrote:
The following does work:

1. Select a message in the message list
2. Create a new message (or reply to the selected one which doesn't make sense since it will normally be quoted anyway)
3. In the compose window select "Options > Quote Message".

If you start the new message or reply from a tab, it doesn't work as you reported. For me it works if you open a message in a new window and then use "Reply" or "Write".

Comment 2

[EarlgreyTea]

(In reply to Francesco from comment #1)

For me it works if you open a message in a new window and then use "Reply" or "Write".

Thank you for confirming.
I tried testing again. And I confirmed that you are right.

Comment 3

[Francesco]

Wouldn't the summary be better like:
In Thunderbird 115 and later, "Options > Quote Message" does not work when composing a new message (or reply) from a message opened in a new tab.

Wanting to quote in a reply is not a function one would use, right?

Comment 4

[EarlgreyTea]

Francesco

That does not seem to be the issue I want to report.
What would be the steps for "composing a new message from a message opened in a new tab"?
The new "mailMessageTab" should have a "Reply" button but no "New Message" button.

Wanting to quote in a reply is not a function one would use, right?

Some users may wish to create a reply message with "Automatically quote original message when replying" disabled in Account Settings > Composition and Addressing, and then quote it later to their own liking.

Comment 5

[EarlgreyTea]

I found the location that is causing this bug.

When "Options > Quote Message" is selected, GetSelectedMessages() is called to retrieve the message to quote.
https://searchfox.org/comm-esr115/source/mail/components/compose/content/MsgComposeCommands.js#1573

function GetSelectedMessages() {
  let mailWindow = Services.wm.getMostRecentWindow("mail:3pane");
  if (!mailWindow) {
    return null;
  }
  let tab = mailWindow.document.getElementById("tabmail").currentTabInfo;
  if (tab.mode.name == "mail3PaneTab" && tab.message) {
    return tab.chromeBrowser.contentWindow?.gDBView?.getURIsForSelection();
  } else if (tab.mode.name == "mailMessageTab") {
    return [tab.messageURI];
  }
  return null;
}

If the current tab is "mailMessageTab", it refers to the member "messageURI" in the tab information, which was removed in Bug 1833804, so it seems to return undefind and cause an error.

Comment 6

[EarlgreyTea]

Two months have passed since the report, and I tested it again, but the situation has not changed.
The cause is known and is a regression by Bug 1833804.
I hope this bug is confirmed and fixed.

Comment 7

[Geoff Lankow (:darktrojan) [OOO, back 21 July]]

Attachment: Bug 1868626 - Fix Quote Message so it works with messages open in tabs. r=#thunderbird-reviewers

Comment 8

[Geoff Lankow (:darktrojan) [OOO, back 21 July]]

Your assessment of the problem is correct. Sorry that it took some time to get to.

This function has other issues I haven't tried to fix here. Notably, in comment 1 Francesco says it works if you open a message in a new window then quote it. It doesn't, that only appears to work if the opened message is still selected in the main window. It's probably also very confusing if the user has two main windows open.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/48f0516a4fdd
Fix Quote Message so it works with messages open in tabs. r=aleca

Comment 10

[Wayne Mery (:wsmwk)]

Trivial patch - safe for uplift to 115?

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9379795 [details]
Bug 1868626 - Fix Quote Message so it works with messages open in tabs. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 115.8.1:
https://hg.mozilla.org/releases/comm-esr115/rev/2cffe2dc0517