1868661 - [wpt-sync] Sync PR 43543 - Missing ::first-letter style update for size queries

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43543 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43543
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Missing ::first-letter style update for size queries

Style for ::first-letter pseudo elements are updated as late as possible
to allow nodes to re-attach to make sure any first-letter text node
changes are included when computing style for the first rendered letter.

When the StyleRecalcChange were already marked for ReattachLayoutTree()
when reaching the ::first-letter update, we assumed some ancestor of the
::first-letter element would be re-attached, and the ::first-letter
style being updated in Element::AttachLayoutTree() for the originating
element. But, if the originating element was a size container, and we
skipped style recalc for its descendants, we would mark the stored
StyleRecalcChange for re-attachment of the children when resuming, even
if the originating element itself would be re-attached.

Instead, check that we also did not suppress style recalc for the
originating element for the ::first-letter before skipping its style
update during style recalc.

Bug: 1505250
Change-Id: I8d45c219e0d8c2a2d8ab6e0ec6149d9f34366fad
Reviewed-on: https://chromium-review.googlesource.com/5097303
WPT-Export-Revision: 49d61e819d86b9143706f504575cb844839dfb17

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=115d0e1d4e6189cc00b2edc2553887530063f1d3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b82a9afcafd
[wpt PR 43543] - Missing ::first-letter style update for size queries, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8b82a9afcafd