1868670 - [wpt-sync] Sync PR 43545 - Some fixes for SnapEvents tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43545 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43545
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

Some fixes for SnapEvents tests

This patch addresses failures that occur when the affected tests are
run against the full chrome binary (not just content_shell) with
chromedriver.

Summary of the changes:

• chromedriver throws the error "Action action_sequence failed" when
  the inputs to test_driver.Actions.pointerMove are not integers so
  this patch rounds these inputs to whole numbers.
• chromedriver seems to require the "origin" parameter to
  test_driver.Actions.scroll, otherwise no scroll is observed.
• Element.offset{Top, Left} are integers[1] and
  Element.scroll{Top, Left} may be rounded, so this patch uses
  assert_approx_equals instead of approx_equals with a tolerance of 1px

[1]https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetLeft#:~:text=An integer

Change-Id: I86f9bbbc580d31be56e78f93edc671b6fe46c478
Reviewed-on: https://chromium-review.googlesource.com/5097343
WPT-Export-Revision: d9f7b9d38c99fcce12c26c652dced14bcba13c81

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=45b4597d3cc22a8f6c378dfb04b142ad84b3b9a0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 5 subtests

Status Summary

Firefox

OK : 4
FAIL : 20
TIMEOUT: 6
NOTRUN : 2

Chrome

OK : 5
PASS : 2
FAIL : 23
ERROR : 2

Safari

OK : 4
FAIL : 20
TIMEOUT: 6
NOTRUN : 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes via scrollTo: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes via scrollTo: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes on touch scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on wheel scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on scrollbar drag: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on keydown press: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on user scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes on touch scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on wheel scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on scrollbar drag: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on keydown press: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on user scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanging/snapchanging-after-layout-change.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • snapchanging fires after layout change: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-user-root-scroll.tentative.html [wpt.fyi]: TIMEOUT (Chrome: ERROR, Safari: TIMEOUT)
  • touch scrolling fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • mouse wheel scroll triggers snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • scrollbar dragging fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanging fires as scroll moves through different snap targets.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
  • snapchanging doesn't fire if scroll doesn't reach different snap targets.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-user-scroll.tentative.html [wpt.fyi]: TIMEOUT (Chrome: ERROR, Safari: TIMEOUT)
  • touch scrolling fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • mouse wheel scroll triggers snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • scrollbar dragging fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanging fires as scroll moves through different snap targets.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
  • snapchanging doesn't fire if scroll doesn't reach different snap targets.: NOTRUN (Chrome: PASS, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f64e5c10c67
[wpt PR 43545] - Some fixes for SnapEvents tests, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f64e5c10c67