1868697 - Investigate fxa-toolbar-menu-button toolbarbutton in browser_asrouter_toolbarbadge.js that is failing Tier 2 a11y_checks for New Tab Page

Status: NEW

(Firefox :: New Tab Page, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate the existent test that would fail once the a11y-checks are enabled in the CI, the failing test was failed-if by the bug 1854514.

This task is to track the investigation into the reasons this test failed and to be able to backtrack this test once it's resolved.

Tests failing (with the stack trace:

Path	Error	El ID	El tagName	El className	Stack trace	
browser/components/newtab/test/browser/browser_asrouter_toolbarbadge.js	Node is not accessible via accessibility API	fxa-toolbar-menu-button	toolbarbutton	toolbarbutton-1 chromeclass-toolbar-additional subviewbutton-nav	"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:342
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:659
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:638
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:741
chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_toolbarbadge.js:test_fxa_badge_shown_nodelay:36
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the test failure is resolved and its associated bug is closed, remove the fail-if condition for a11y_checks from the appropriate file/section to ensure better test coverage and to avoid regressions in a11y of this component.

Comment 1

[Anna Yeddi [:ayeddi]]

It appears to be that the toolbarbutton for Fx Accounts is hidden when the click takes place in the test

Comment 2

[Anna Yeddi [:ayeddi]]

FYI Bug 1877196 moved the test to browser/components/asrouter/tests/browser/browser_asrouter_toolbarbadge.js.