Closed
Bug 186873
Opened 22 years ago
Closed 22 years ago
Incorrect charCode comparison in button.xml
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
VERIFIED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
Attachments
(1 file)
|
837 bytes,
patch
|
neil
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
As reported by Neil earlier, charCode is an integer value. Therefore, if (event.charCode <= ' ') should be if (event.charCode <= 32)
|
Assignee | |
Comment 1•22 years ago
|
||
Without this fix, keys that cannot be accesskeys will trigger accesskey search in buttons.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 110191 [details] [diff] [review] Fixes charCode comparison Can charCode ever be < 0 ?
Attachment #110191 -
Flags: superreview?(hewitt)
Attachment #110191 -
Flags: review?(neil)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 110191 [details] [diff] [review] Fixes charCode comparison No, charCode is a PRUint32
Attachment #110191 -
Flags: review?(neil) → review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #110191 -
Flags: superreview?(hewitt) → superreview?(jaggernaut)
|
||
Comment 4•22 years ago
|
||
Comment on attachment 110191 [details] [diff] [review] Fixes charCode comparison sr=jag
Attachment #110191 -
Flags: superreview?(jaggernaut) → superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•