1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: recently closed search.png

Found in

• Firefox 122.0a1

Affected versions

• Firefox 122.0a1

Tested platforms

• Affected platforms: Windows 10/11
• Unaffected platforms: macOS 14.1.2, Ubuntu 22.04

Preconditions

• Have browser.firefox-view.search.enabled set to true

Steps to reproduce

1. Launch Firefox and access Firefox View
2. Go to Recently Closed Tabs section
3. Look at the search box

Expected result

• The message box is a bit longer so it can contain the message like it does on macOS and Ubuntu

Actual result

• The message "Search recently closed tabs" is cut out in the box

Additional notes

• The issue can be seen in the attachment
• Only Windows is affected

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1868776 - "Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r?#fxview-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e11ea7d34e4
"Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_firefoxview_paused.js.

• backout: https://hg.mozilla.org/integration/autoland/rev/a64d343d6e8bf83501a4c79da8e63c9248a5ff0e
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=W9M0rmpXQxucPzMt31dTKg.0&revision=8e11ea7d34e4fa52636c064c7720463ad90fdb41
• failure log: https://treeherder.mozilla.org/logviewer?job_id=441167431&repo=autoland&lineNumber=3891

17:01:42 INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/firefoxview-next/browser_firefoxview_paused.js | Expected the render method spy on element view-recentbrowsing to not be called - Got false, expected true
17:01:48 INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/firefoxview-next/browser_firefoxview_paused.js | Expected the render method spy on element view-recentlyclosed to not be called - Got false, expected true
17:01:48 INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/firefoxview-next/browser_firefoxview_paused.js | Expected the render method spy on element fxview-tab-list to not be called - Got false, expected true

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78f88acf0cbc
"Search recently closed tabs" placeholder text is cut off in the search box in Firefox View r=fxview-reviewers,kcochrane

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/78f88acf0cbc

Comment 6

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the Recently closed tabs placeholder is no longer cut off in the search box on Firefox 123.0a1 (2024-01-02) on Windows 11.

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jsudiaman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Jonathan Sudiaman [:jsudiaman]]

Search is disabled by default on Firefox 122.