1868875 - Respect LINK_BEHAVIOR_CURRENTTAB flag in taskbar tabs

Status: ASSIGNED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Nipun Shukla]

If a link is opened by the OS into the (coincidentally) correct taskbar window, we don't respect the LINK_BEHAVIOR_CURRENTTAB flag and it stays in the new tab that was created.

Comment 1

[[e-mail]]

When firefox.exe is launched with a URL parameter, it routes the URL to a new tab in the most recently active window. Since I didn't write any extension code to get firefox to be aware of a distinction between "normal windows" and "taskbar windows", the URL might very well get routed into a taskbar window. That's OK for now, because the extension will reroute the request to a normal window anyhow.

BUT there's an exception... if the request happens to be in the scope of the taskbar window it lands in, the extension doesn't reroute it (nor should it). So this is for example, a link to a tweet is clicked from Outlook and the Twitter taskbar window happens to be the most recently active anyway, so the request lands in a new tab in the Twitter window.

But what if you have LINK_BEHAVIOR_CURRENTTAB set for Twitter? You actually do want to reroute the request from the new tab back into the existing tab in the Twitter window. That doesn't happen today.

This is probably new code in handleNewTaskbarTab, which already handles creating a new window when LINK_BEHAVIOR_NEWWINDOW is set on the site.

Comment 2

[Michael Hughes]

To test this, install a site, set it to LINK_BEHAVIOR_CURRENTTAB, and have only the site window open. Then copy a URL for that site to the clipboard. Do WIN+R, paste in the URL, and press enter. With the bug, the URL you launched from Windows will be in a second tab in the site window. With the fix, there will be only one tab open and it will have navigated to your launched URL.