1868922 - The Suggest Rust backend shouldn't lowercase query strings

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

The Suggest Rust backend lowercases query strings before sending them to the Rust component. That's not necessary anymore and probably not even desirable since the component now handles that internally.

Comment 1

[Drew Willcoxon :adw]

https://github.com/mozilla/application-services/commit/f3cd74035a5eafcdd5925aadc2859ec59583ecdb hasn't been vendored into m-c yet, so this is blocked until then.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1868922: Pass user's query as is to Rust component to keep string cases

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d558120aba19
Pass user's query as is to Rust component to keep string cases r=adw

Comment 4

[Cristian Tuns]

Backed out for causing xpcshell failures in test_tab_quickwrite.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | services/sync/tests/unit/test_tab_quickwrite.js | test_tab_quickwrite_works - [test_tab_quickwrite_works : 58] false == true

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0253ebfe13cc
Pass user's query as is to Rust component to keep string cases r=adw

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0253ebfe13cc