1869041 - [wpt-sync] Sync PR 43577 - Revert "Prefetch: Allow use of HTTP cache for same-site prefetches"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43577 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43577
Details from upstream follow.

Ben Pastene <[e-mail]> wrote:

Revert "Prefetch: Allow use of HTTP cache for same-site prefetches"

This reverts commit b54f90853104c8275286bf256fe1849236b5c459.

Reason for revert: prefetch-uses-cache.sub web_tests failures, eg:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/b8762255064072594513/overview

Original change's description:

Prefetch: Allow use of HTTP cache for same-site prefetches

Adds functionality behind a feature flag that's enabled-by-default. In
addition to adding WPT and some browser test coverage, it also makes
most resources in external/wpt/speculation-rules/prefetch/resources
non-cacheable to prevent them from interfering with tests (in
particular we rely on request headers being injected by the wpt
server, which doesn't happen when a cached response is used).

Bug: 1506051
Change-Id: I0295feefb6621c54778ae62334cf20d711f69145
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5080758
Commit-Queue: Adithya Srinivasan \<[e-mail]>
Reviewed-by: Jeremy Roman \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1235075}

Bug: 1506051, 1509944
Change-Id: I14de1c53991c1f3a40e7db57835c03aaec1a270d
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/5106474
WPT-Export-Revision: 386ae3f6123304e46530cc5589d9d95111e3439d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 43577 applied with additional changes from upstream: ea980464c32f84fcdfc1d13d3f04eef19cf298f2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0e34922de8bea98dd6a7e9c7174bbe866fa154c

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0140af25314f
[wpt PR 43577] - Revert "Prefetch: Allow use of HTTP cache for same-site prefetches", a=testonly

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0140af25314f