1869160 - Perma spidermonkey test failures related to WeakMap/WeakSet when Gecko 122 merges to Beta on 2023-12-18

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Cosmin Sabou [:CosminS]]

Central as beta-simulation

Failure logs:

• spidermonkey failures - https://treeherder.mozilla.org/logviewer?job_id=439542849&repo=try
• xpcshell failures - https://treeherder.mozilla.org/logviewer?job_id=439544986&repo=try

How to run these simulations

Log snippet:

59969	TEST-UNEXPECTED-FAIL | testWeakMap_basicOperations_symbols_as_keys | /builds/worker/checkouts/gecko/js/src/jsapi-tests/testWeakMap.cpp:123:CHECK failed: SetWeakMapEntry(cx, map, key, val) -- TypeError: WeakMap key Symbol("test") must be an object or an unregistered symbol
84945	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/iterable-with-symbol-values.js | (args: "") [0.1 s]
84967	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/prototype/delete/delete-symbol-entry.js | (args: "") [0.1 s]
84989	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/prototype/has/returns-true-when-symbol-value-present.js | (args: "") [0.1 s]
84999	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/prototype/has/returns-false-when-symbol-value-not-present.js | (args: "") [0.1 s]
85015	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/prototype/add/returns-this-symbol.js | (args: "") [0.1 s]
85024	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/prototype/add/returns-this-when-ignoring-duplicate-symbol.js | (args: "") [0.1 s]
85032	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/prototype/add/adds-symbol-element.js | (args: "") [0.1 s]
85720	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/iterable-with-symbol-keys.js | (args: "") [0.1 s]
85752	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/delete/returns-false-when-symbol-key-not-present.js | (args: "") [0.0 s]
85758	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/delete/delete-entry-with-symbol-key.js | (args: "") [0.1 s]
85772	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/delete/delete-entry-with-symbol-key-initial-iterable.js | (args: "") [0.1 s]
85788	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/has/returns-false-when-symbol-key-not-present.js | (args: "") [0.1 s]
85797	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/has/returns-true-when-symbol-key-present.js | (args: "") [0.1 s]
85818	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/set/adds-symbol-element.js | (args: "") [0.1 s]
85833	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/get/returns-undefined-with-symbol-key.js | (args: "") [0.1 s]
85840	TEST-UNEXPECTED-FAIL | test262/built-ins/WeakMap/prototype/get/returns-value-with-symbol-key.js | (args: "") [0.1 s]
115001	TEST-UNEXPECTED-FAIL | non262/WeakMap/symbols.js | (args: "") [0.1 s]
115065	make[1]: *** [Makefile:63: check-jstests] Error 1
115067	make: *** [Makefile:216: check-jstests] Error 2

[task 2023-12-10T10:11:31.707Z] TEST-PASS | testWeakMap_keyDelegates | ok
[task 2023-12-10T10:11:31.707Z] testWeakMap_basicOperations_symbols_as_keys
[task 2023-12-10T10:11:31.730Z] /builds/worker/checkouts/gecko/js/src/jsapi-tests/testWeakMap.cpp:123:CHECK failed: SetWeakMapEntry(cx, map, key, val) -- TypeError: WeakMap key Symbol("test") must be an object or an unregistered symbol
[task 2023-12-10T10:11:31.731Z] TEST-UNEXPECTED-FAIL | testWeakMap_basicOperations_symbols_as_keys | /builds/worker/checkouts/gecko/js/src/jsapi-tests/testWeakMap.cpp:123:CHECK failed: SetWeakMapEntry(cx, map, key, val) -- TypeError: WeakMap key Symbol("test") must be an object or an unregistered symbol
[task 2023-12-10T10:11:31.731Z] testWeakMap_setWeakMapEntry_invalid_key
[task 2023-12-10T10:11:31.757Z] TEST-PASS | testWeakMap_setWeakMapEntry_invalid_key | ok

[task 2023-12-10T10:13:42.883Z] TEST-PASS | test262/built-ins/WeakSet/name.js | (args: "") [0.1 s]
[task 2023-12-10T10:13:42.884Z] ## test262/built-ins/WeakSet/iterable-with-symbol-values.js: rc = 3, run time = 0.052463
[task 2023-12-10T10:13:42.884Z] /builds/worker/checkouts/gecko/js/src/tests/test262/built-ins/WeakSet/iterable-with-symbol-values.js:25:18 TypeError: WeakSet value Symbol("a description") must be an object or an unregistered symbol
[task 2023-12-10T10:13:42.884Z] Stack:
[task 2023-12-10T10:13:42.884Z]   WeakSet.prototype.add@/builds/worker/checkouts/gecko/js/src/tests/test262/built-ins/WeakSet/iterable-with-symbol-values.js:25:18
[task 2023-12-10T10:13:42.884Z]   @/builds/worker/checkouts/gecko/js/src/tests/test262/built-ins/WeakSet/iterable-with-symbol-values.js:27:9
[task 2023-12-10T10:13:42.884Z] TEST-UNEXPECTED-FAIL | test262/built-ins/WeakSet/iterable-with-symbol-values.js | (args: "") [0.1 s]

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1869160 - Disable tests for symbols as weakmap keys outside nightly builds

This feature is only present in nightly builds.

Comment 2

[Jon Coppeard (:jonco)]

The patch above should fix this. Beta simulation try push:

https://treeherder.mozilla.org/jobs?repo=try&revision=98460e5a7b12086f5df721a5bc20d4984234152a
https://treeherder.mozilla.org/jobs?repo=try&revision=198733e11a3436bee1f8cf4a54bd0b071128b2ff

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/984ac2f3cb37
Disable tests for symbols as weakmap keys outside nightly builds r=allstarschh

Comment 4

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b30e0d96daca

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/984ac2f3cb37