1869233 - Disabled checkboxes are not so visible on the Preferences page

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 122.0a1 (2023-12-10)

Affected versions

• 122.0a1 (2023-12-10)

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 22
• Unaffected platforms: none

Steps to reproduce

1. Open Firefox and set it as the default browser.
2. Observe the checkmark before the Always check if Nightly is your default browser string.

Expected result

• The checkmark has a blue tint.

Actual result

• The checkmark is not so visible and has a grey tint.

Regression

• Last good revision: 2462e8026fd78d968362eacf10e6ae2dee025e1e
  First bad revision: d5a2cb7b9272b5c9cdfe4a0397c570ce5f9260bf
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2462e8026fd78d968362eacf10e6ae2dee025e1e&tochange=d5a2cb7b9272b5c9cdfe4a0397c570ce5f9260bf

Additional notes

• Attached a screenshot.
• This applies to other disabled checkboxes as well.

Comment 1

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1867769, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1869233 - Don't fade disabled checkboxes. r=dao

The non-native theme already applies disabled appearance on its own.
Applying opacity on top fades them quite a lot.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed758645084d
Don't fade disabled checkboxes. r=dao,desktop-theme-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ed758645084d

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Hello, I looked over this today with the latest Nightly 122.0a1 (2023-12-12) on Windows 10x64, macOS 12, and Ubuntu 22. It seems that the disabled checkboxes are more visible than before.
Emilios is this the expected behavior now and the previous blue color no longer needs to be displayed? Attached a screenshot for better visibility. Thank you in advance!

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Yes, that's expected. It's the same behavior as data:text/html,<input type=checkbox checked disabled>

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

Yes, that's expected. It's the same behavior as data:text/html,<input type=checkbox checked disabled>

Thank you!