1869346 - Rework how canvas accesses shared surfaces in the compositor process

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1869346 - Rework how canvas accesses shared surfaces in the compositor process.

This patch adds plumbing to allow sharing ExternalImageId via
SurfaceDescriptor. This will be used in a future patch by WebGL and
WebGPU to avoid extra copies. It also refactors how CanvasTranslator
gets a SourceSurfaceSharedDataWrapper pointer by ensuring the surfaces
are kept alive long enough even if the CompositorManagerParent actor is
destroyed before CanvasManagerParent and its children. Now we keep the
surfaces around until all of these dependent objects have been freed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11451cccc88c
Rework how canvas accesses shared surfaces in the compositor process. r=gfx-reviewers,lsalzman

Comment 3

[Cristian Tuns]

Backed out for causing build bustages in ipc_message_utils.h

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/ipc/chromium/src/chrome/common/ipc_message_utils.h(687,53): error: no member named 'Write' in 'mozilla::ipc::IPDLParamTraits<mozilla::wr::ExternalImageSource>'

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Looks like a missing include in the IPDL.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dab6b48a2a59
Rework how canvas accesses shared surfaces in the compositor process. r=gfx-reviewers,lsalzman

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dab6b48a2a59