1869448 - Update PDF.js to new version 76e3e5202195503b414aa0070fc2e3a2fa19706c from 2023-12-11 21:30:53

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 14 commits. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.mjs | 10 ++++----
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 18 ++++++++------
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 17 +++++---------
toolkit/components/pdfjs/content/web/viewer.html | 1 +
toolkit/components/pdfjs/content/web/viewer.mjs | 17 +++++---------
toolkit/components/pdfjs/moz.yaml | 4 +-
7 files changed, 32 insertions(+), 39 deletions(-)

---

844c4ebad3dc6949c6c9fd30a234d986032b73b3 by Emiel Molenaar

https://github.com/mozilla/pdf.js/commit/844c4ebad3dc6949c6c9fd30a234d986032b73b3
Authored: 2023-12-11 17:42:43 +0100
Committed: 2023-12-11 17:42:43 +0100

Adds missing button closing tag

Files Modified:

• web/viewer.html

---

b388d407a8cad2ad06a75a072dcd208ef992034e by dependabot[bot]

https://github.com/mozilla/pdf.js/commit/b388d407a8cad2ad06a75a072dcd208ef992034e
Authored: 2023-12-11 12:14:23 +0000
Committed: 2023-12-11 12:14:23 +0000

Bump actions/deploy-pages from 2 to 3

Bumps actions/deploy-pages from 2 to 3.

• Release notes
• Commits

---

updated-dependencies:

• dependency-name: actions/deploy-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• .github/workflows/publish_website.yml

---

93143c03fa9915bc7afee51cb75ef121ff2acb46 by dependabot[bot]

https://github.com/mozilla/pdf.js/commit/93143c03fa9915bc7afee51cb75ef121ff2acb46
Authored: 2023-12-11 12:14:19 +0000
Committed: 2023-12-11 12:14:19 +0000

Bump actions/setup-python from 4 to 5

Bumps actions/setup-python from 4 to 5.

• Release notes
• Commits

---

updated-dependencies:

• dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• .github/workflows/fluent_linter.yml
• .github/workflows/font_tests.yml

---

82be74d03614979fea6c346cd0f4d9086a01e819 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/82be74d03614979fea6c346cd0f4d9086a01e819
Authored: 2023-12-09 15:00:11 +0100
Committed: 2023-12-09 16:59:43 +0100

Set a print listener as soon as possible in the autoprint integration test

This test intermittently fails, likely because the auto-print is triggered fast enough
that we don't manage to get it.
So this patch aims to try to set a listener very early in order to be sure that
we'll be aware that a print has been triggered.

Files Modified:

• test/integration/scripting_spec.mjs
• test/integration/test_utils.mjs

---

92c15a61f1e62733d1221e4767e2f11d229a4feb by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/92c15a61f1e62733d1221e4767e2f11d229a4feb
Authored: 2023-12-09 09:40:07 +0100
Committed: 2023-12-09 14:29:31 +0100

Re-factor how the sandboxBundleSrc option is passed to PDFScriptingManager

Given that this option isn't used in the Firefox PDF Viewer, we can (ever so slightly) reduce the amount of code needed.

Files Modified:

• web/app.js
• web/chromecom.js
• web/firefoxcom.js
• web/genericcom.js
• web/pdf_scripting_manager.component.js
• web/pdf_scripting_manager.js

---

e25cf1ba6f92d1d650705742d0fe6b39f49d77f7 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/e25cf1ba6f92d1d650705742d0fe6b39f49d77f7
Authored: 2023-12-09 14:12:40 +0100
Committed: 2023-12-09 14:15:18 +0100

Don't run beforeunload callback when closing page in integration tests

For now, running such callbacks is disabled in Firefox but there are some
plan to reenable them: https://bugzilla.mozilla.org/show_bug.cgi?id=1824220
Having them blocks us to switch to bidi with Chrome.

Files Modified:

• test/integration/test_utils.mjs

---

a1d859c0829d50ed4cab610a0216e7ef4d8f718d by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/a1d859c0829d50ed4cab610a0216e7ef4d8f718d
Authored: 2023-12-09 10:41:37 +0100
Committed: 2023-12-09 14:13:11 +0100

Disable the "should compress and save text" unit-test in Node.js (PR 17202 follow-up)

It seems this unit-test now fails consistently in "all" up-to-date Node.js versions. We should probably try and understand why, but for now just disable it to get passing CI tests.

Files Modified:

• test/unit/annotation_spec.js
• test/unit/test_utils.js

---

63eb8991a3e2d86aa562e0a444fe90dc01e7f7bb by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/63eb8991a3e2d86aa562e0a444fe90dc01e7f7bb
Authored: 2023-12-09 10:30:23 +0100
Committed: 2023-12-09 10:36:18 +0100

Support Annotations with corrupt /BS-entries

There's obviously a few things wrong with the Annotations in the referenced PDF document, however parsing of an Annotation shouldn't just break if the /BS-entry isn't a dictionary.

Files Added:

• test/pdfs/pypdf2332.pdf.link

Files Modified:

• src/core/annotation.js
• test/test_manifest.json

---

d04d28a56d1454d2721513b451223c2333ffb8e3 by Henrik Skupin

https://github.com/mozilla/pdf.js/commit/d04d28a56d1454d2721513b451223c2333ffb8e3
Authored: 2023-12-08 21:59:18 +0100
Committed: 2023-12-08 21:59:18 +0100

Remove unnecessary loop for closing open pages

Files Modified:

• test/test.mjs

---

4db01746d8e7dc2c5aa86d584db285b4f28e1c50 by Henrik Skupin

https://github.com/mozilla/pdf.js/commit/4db01746d8e7dc2c5aa86d584db285b4f28e1c50
Authored: 2023-10-25 10:37:43 +0200
Committed: 2023-12-08 20:32:50 +0100

Run integration tests with WebDriver BiDi instead of CDP for Firefox.

Files Modified:

• test/test.mjs

---

a067d38ce32102170384811cc16e44a6908c8058 by Henrik Skupin

https://github.com/mozilla/pdf.js/commit/a067d38ce32102170384811cc16e44a6908c8058
Authored: 2023-12-08 12:27:44 +0100
Committed: 2023-12-08 12:27:44 +0100

Update Puppeteer to version 21.6.0 and force "CDP" protocol

Files Modified:

• package-lock.json
• package.json
• test/test.mjs

---

c63af10191cfb13a7f1db1da68fb652e0b40f931 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/c63af10191cfb13a7f1db1da68fb652e0b40f931
Authored: 2023-12-06 15:27:31 +0100
Committed: 2023-12-07 17:00:12 +0100

Use page.evaluateHandle when we want to await on document promises in integration tests

For reference: https://github.com/mozilla/pdf.js/pull/17378#issuecomment-1842864939

Files Modified:

• test/integration/freetext_editor_spec.mjs
• test/integration/ink_editor_spec.mjs
• test/integration/stamp_editor_spec.mjs
• test/integration/test_utils.mjs

---

628054ee5323c90d4da0f6ab4869c941cd81c9e8 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/628054ee5323c90d4da0f6ab4869c941cd81c9e8
Authored: 2023-12-07 16:58:09 +0100
Committed: 2023-12-07 16:58:09 +0100

Collect a few non-MOZCENTRAL AppOptions default values together

Ideally we want as few build-specific branches as possible when defining the default values, to improve readability, hence this change cannot hurt.

Files Modified:

• web/app_options.js

---

d7bec1b527dad0c0645234a492ad011ba1abf10a by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/d7bec1b527dad0c0645234a492ad011ba1abf10a
Authored: 2023-12-04 16:19:25 +0100
Committed: 2023-12-04 16:39:45 +0100

Limit the amount of console "spam" during fuzz tests (PR 17337 follow-up)

Having just tested PR 17337 locally I noticed that especially the JpxImage-test causes a "ridiculous" amount of warning messages to be printed, which doesn't seem helpful.
Given that only actual Errors should be relevant here, we can easily disable this logging during the tests.

Files Modified:

• src/pdf.image_decoders.js
• test/fuzz/jbig2_image.fuzz.js
• test/fuzz/jpeg_image.fuzz.js
• test/fuzz/jpx_image.fuzz.js
• test/unit/pdf.image_decoders_spec.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=d905a3e4c330c43c7fef93c00773ba455333a0f6

Comment 2

[Update Bot]

Attachment: Bug 1869448 - Update PDF.js to 76e3e5202195503b414aa0070fc2e3a2fa19706c

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0603dbbfc9b4
Update PDF.js to 76e3e5202195503b414aa0070fc2e3a2fa19706c r=pdfjs-reviewers,Snuffleupagus

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0603dbbfc9b4