1869457 - gecko/xpcom/base/AvailableMemoryWatcherLinux.cpp:133:36: runtime error: division by zero

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Tyson Smith [:tsmith]]

Found while fuzzing m-c 20231208-31a6430ad25b (--enable-address-sanitizer --enable-fuzzing)

This is being reported some what frequently but a reliable test cases is unavailable. I think this is related to when a OOM happens and when a check is performed.

/gecko/xpcom/base/AvailableMemoryWatcherLinux.cpp:133:36: runtime error: division by zero
    #0 0x7fe61dc49b32 in mozilla::nsAvailableMemoryWatcher::IsMemoryLow() /gecko/xpcom/base/AvailableMemoryWatcherLinux.cpp:133:36
    #1 0x7fe61dc9ef11 in operator() /gecko/xpcom/base/AvailableMemoryWatcherLinux.cpp:175:13
    #2 0x7fe61dc9ef11 in mozilla::detail::RunnableFunction<mozilla::nsAvailableMemoryWatcher::Notify(nsITimer*)::$_0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:548:5
    #3 0x7fe61df1371d in nsThread::ProcessNextEvent(bool, bool*) /gecko/xpcom/threads/nsThread.cpp:1193:16
    #4 0x7fe61df20fda in NS_ProcessNextEvent(nsIThread*, bool) /gecko/xpcom/threads/nsThreadUtils.cpp:480:10
    #5 0x7fe61fba2b99 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /gecko/ipc/glue/MessagePump.cpp:330:5
    #6 0x7fe61f9c956a in RunInternal /gecko/ipc/chromium/src/base/message_loop.cc:370:10
    #7 0x7fe61f9c956a in RunHandler /gecko/ipc/chromium/src/base/message_loop.cc:363:3
    #8 0x7fe61f9c956a in MessageLoop::Run() /gecko/ipc/chromium/src/base/message_loop.cc:345:3
    #9 0x7fe61df09f70 in nsThread::ThreadFunc(void*) /gecko/xpcom/threads/nsThread.cpp:370:10
    #10 0x7fe6458eb11f in _pt_root /gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5
    #11 0x55ee88eeb74a in asan_thread_start(void*) /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:225:31
    #12 0x7fe6460caac2 in start_thread nptl/pthread_create.c:442:8
    #13 0x7fe64615b813 in __clone misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1869457 - Don't attempt to compute low-memory conditions if we don't know how much memory is in the system r=KrisWright

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1c8877fa4c8
Don't attempt to compute low-memory conditions if we don't know how much memory is in the system r=KrisWright

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b1c8877fa4c8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gsvelto, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Gabriele Svelto [:gsvelto]]

This is not worth uplifting