Closed
Bug 1869497
Opened 2 years ago
Closed 2 years ago
Mark all naked functions as no_profile_instrument_function
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox122 fixed)
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
Details
Attachments
(1 file)
A function marked as naked should probably not be a candidate for instumentation at all, see https://github.com/llvm/llvm-project/issues/74573 for the upstream discussion.
|
Assignee | |
Comment 1•2 years ago
|
||
In the fx codebase, we tend to use attribute((naked)) for plain
assembly functions with a C interface. Instrumenting these functions can
mess up this assembly, so we conservatively also want to prevent
instrumentation.
Pushed by sguelton@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acb47c6c2739
Introduce MOZ_NAKED to centralize all attributes we expect from naked r=glandium,win-reviewers,mhowell
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•