1869558 - Port applicationServerKey validation mochitests to WPT

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1869558 - Part 2: Port applicationServerKey validation tests to WPT r=asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9c41a2aac8b
Port applicationServerKey validation tests to WPT r=asuth

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43672 for changes under testing/web-platform/tests

Comment 4

[Iulian Moraru]

Backed out for causing wpt failures on subscribe-with-faulty-applicationServerKey.https.window.html.

• Push with failures

• Failure log

• Backout link

[task 2023-12-14T20:55:52.906Z] 20:55:52     INFO - TEST-PASS | /push-api/subscribe-with-faulty-applicationServerKey.https.window.html | Reject empty Uint8Array applicationServerKey 
[task 2023-12-14T20:55:52.906Z] 20:55:52     INFO - TEST-UNEXPECTED-FAIL | /push-api/subscribe-with-faulty-applicationServerKey.https.window.html | Reject a key that is not a valid point on P-256 curve - promise_rejects_dom: function "function() { throw e }" threw object "AbortError: Error retrieving push subscription." that is not a DOMException InvalidAccessError: property "code" is equal to 20, expected 15
[task 2023-12-14T20:55:52.966Z] 20:55:52     INFO - TEST-OK | /push-api/subscribe-with-faulty-applicationServerKey.https.window.html | took 1022ms
[task 2023-12-14T20:55:52.967Z] 20:55:52     INFO - Restarting browser for new test group
[task 2023-12-14T20:55:53.267Z] 20:55:53     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2023-12-14T20:55:53.349Z] 20:55:53     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2023-12-14T20:55:53.349Z] 20:55:53     INFO - Closing logging queue
[task 2023-12-14T20:55:53.350Z] 20:55:53     INFO - queue closed
[task 2023-12-14T20:55:53.361Z] 20:55:53     INFO - Setting up ssl
[task 2023-12-14T20:55:53.375Z] 20:55:53     INFO - certutil | b''
[task 2023-12-14T20:55:53.388Z] 20:55:53     INFO - certutil | b''
[task 2023-12-14T20:55:53.396Z] 20:55:53     INFO - certutil | b'\nCertificate Nickname                                         Trust Attributes\n                                                             SSL,S/MIME,JAR/XPI\n\nweb-platform-tests                                           CT,, \n'
[task 2023-12-14T20:55:53.923Z] 20:55:53     INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test_runner
[task 2023-12-14T20:55:54.983Z] 20:55:54     INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.TestRunnerActivity -a android.intent.action.MAIN --es env0 MOZ_CRASHREPORTER=1 --es env1 MOZ_CRASHREPORTER_NO_REPORT=1 --es env2 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env4 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env6 R_LOG_LEVEL=6 --es env7 R_LOG_DESTINATION=stderr --es env8 R_LOG_VERBOSE=1 --es env9 MOZ_PROCESS_LOG=/tmp/tmpwc_ndws7pidlog --es env10 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es arg0 -no-remote --es arg1 -profile --es arg2 /data/local/tmp/test_root/profile --es arg3 --marionette --es arg4 about:blank --ez use_multiprocess True
[task 2023-12-14T20:55:56.063Z] 20:55:56     INFO - Starting runner
[task 2023-12-14T20:55:58.868Z] 20:55:58     INFO - TEST-START | /sanitizer-api/element-set-sanitized-html.https.html

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

This is why we need a good test 🙂 (I should have ran the test on Androd btw)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1869558 - Part 1: Add validation step for subscribeWithKey r=jonalmeida

Ideally this validation steps should be shared in PushManager::Subscribe, but that's out of scope for this bug. For now this just copypastes the step from dom/push/PushService.sys.mjs.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00002cc231f4
Part 1: Add validation step for subscribeWithKey r=jonalmeida,geckoview-reviewers
https://hg.mozilla.org/integration/autoland/rev/47f75ac9d8c4
Part 2: Port applicationServerKey validation tests to WPT r=asuth

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at dom/push/test/test_permission_granted.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/3116793fe4c31e33bf22dea10ff07fa7c72375dd

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | dom/push/test/test_permission_granted.html | For now a connection error should occur - got "InvalidAccessError", expected "AbortError"

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

This is why we need a good test, second time

Let's see this finally passes all test (except the one in the third commit, that's expected to fail for now) https://treeherder.mozilla.org/jobs?repo=try&revision=68e1998444c20de18444e8cb79818aa6a1eb2599

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fac25fff037
Part 1: Add validation step for subscribeWithKey r=jonalmeida,geckoview-reviewers
https://hg.mozilla.org/integration/autoland/rev/c4306475b0ef
Part 2: Port applicationServerKey validation tests to WPT r=asuth

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4fac25fff037
https://hg.mozilla.org/mozilla-central/rev/c4306475b0ef

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot