1869574 - Remove the wants-back-button hack that was added for Report Broken Site

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

We should be able to drop the wants-back-button hack from reportBrokenSitePanel.inc.xhtml if we alter this part of PanelMultiView.sys.mjs by dropping headerWantsBackButton and changing the if-statement to just:

if (!headerBackButton)

(Itiel assures me that there is no need to check for headerInfoButton in that if-statement).

Comment 1

[Itiel]

(In reply to Thomas Wisniewski [:twisniewski] from comment #0)

(Itiel assures me that there is no need to check for headerInfoButton in that if-statement).

"assures" is a strong word, but I'm pretty sure that check is not needed. Patch incoming.

Comment 2

[Itiel]

Attachment: Bug 1869574 - Refactor the headerText setter to cater for more panelview needs r?gijs!,twisniewski

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65446098ef64
Refactor the headerText setter to cater for more panelview needs r=twisniewski,Gijs,translations-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/65446098ef64