1869775 - The bookmark tag checkbox is not visible

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: bookmark_tag.gif

Found in

• 122.0a1 (2023-12-13)

Affected versions

• 122.0a1 (2023-12-13)

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 22
• Unaffected platforms: none

Steps to reproduce

1. Open Firefox and a random page and save it as a bookmark.
2. Add a tag for the previously saved bookmark.
3. Open that page and click on the Edit this bookmark button.
4. Click on the tag (if multiple tags are present click on the empty tag area)

Expected result

• The checkbox is visible.

Actual result

• Only the checkmark is visible.

Regression

• Last good revision: 2462e8026fd78d968362eacf10e6ae2dee025e1e
  First bad revision: d5a2cb7b9272b5c9cdfe4a0397c570ce5f9260bf
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2462e8026fd78d968362eacf10e6ae2dee025e1e&tochange=d5a2cb7b9272b5c9cdfe4a0397c570ce5f9260bf

Additional notes

• Attached a screen recording.
• The regression applies only to Edit this bookmark menu from the URL bar.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1867769, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This looks fairly ok, specially given that menu is not used all that much. Atrif, what was the behavior before my patch?

Comment 3

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: bookmark_tag_01.gif

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

This looks fairly ok, specially given that menu is not used all that much. Atrif, what was the behavior before my patch?

Hello Emilio! The checkbox had a darker blue color. See the attached screen recording.

Comment 4

[Dão Gottwald [:dao]]

This is fine as-is given that each of these rows acts as a click target for the embedded checkbox.