1869818 - Crash in [@ mozilla::ipc::MessageChannel::AssertWorkerThread | mozilla::ipc::MessageChannel::NextSeqno]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/bf6f9c41-4f71-4a69-9eda-f9e090231213

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(mWorkerThread && mWorkerThread->IsOnCurrentThread()) (not on worker thread!)

Top 10 frames of crashing thread:

0  xul.dll  AnnotateMozCrashReason  mfbt/Assertions.h:46
0  xul.dll  mozilla::ipc::MessageChannel::AssertWorkerThread const  ipc/glue/MessageChannel.h:503
0  xul.dll  mozilla::ipc::MessageChannel::NextSeqno  ipc/glue/MessageChannel.h:427
0  xul.dll  mozilla::ipc::MessageChannel::Send  ipc/glue/MessageChannel.cpp:765
1  xul.dll  mozilla::ipc::IToplevelProtocol::CreateSharedMemory  ipc/glue/ProtocolUtils.cpp:736
2  xul.dll  mozilla::ipc::IProtocol::CreateSharedMemory  ipc/glue/ProtocolUtils.cpp:369
2  xul.dll  mozilla::ipc::IProtocol::AllocShmem  ipc/glue/ProtocolUtils.cpp:471
3  xul.dll  mozilla::gfx::DrawTargetWebgl::Init  dom/canvas/DrawTargetWebgl.cpp:407
4  xul.dll  mozilla::gfx::DrawTargetWebgl::Create  dom/canvas/DrawTargetWebgl.cpp:870
5  xul.dll  mozilla::layers::CanvasTranslator::CreateDrawTarget  gfx/layers/ipc/CanvasTranslator.cpp:732

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

We should probably refuse to use CanvasWorkers in conjunction with DrawTargetWebgl / accelerated canvas.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1869818 - Disable accelerated canvas if canvas worker threads are enabled.

Accelerated canvas requires that the canvas worker threads are disabled.
Since CanvasChild is a per thread singleton, we cannot meaningfully give
different behaviour to D2D canvas and accelerated (WebGL) canvas. For
now just disable accelerated canvas if those prefs are changed.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1829026

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49597d5122ab
Disable accelerated canvas if canvas worker threads are enabled. r=gfx-reviewers,lsalzman

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/49597d5122ab

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.